Error Banner Component

[wdo3650]

Adding error banner component to Fabric.

[philworthington]

I'm wondering if we can just add a class to the chevronButton container to make it visible and have it display none by default instead of relying on js setting inline styles. Something like:

.ms-ErrorBanner-expand {
display: none;

&.is-visible {
display: inline-block;
}
}

and

var _onResize = function(event) {
_clientWidth = _errorBanner.offsetWidth;
if ((_clientWidth - _bufferSize) > _initTextWidth && _initTextWidth < _textContainerMaxWidth) {
_textWidth = "auto";
_chevronButton.className = "ms-ErrorBanner-expand";
_collapse();
} else {
_textWidth = Math.min((_clientWidth - _bufferSize), _textContainerMaxWidth) + "px";
_chevronButton.className += " is-visible";
}
_clipper.style.width = _textWidth;
};

[wdo3650]

Resolved.

[philworthington]

Really nice work and clean code. Just had a few comments on things. Looking good though.

[wdo3650]

Thanks for the suggestions! I made the changes you noted as well as made some additional changes based on your feedback.

[AngelaDiaFazio]

Go home William

On Fri, Nov 20, 2015 at 7:10 PM, William Do [email protected]
wrote:

Reopened #212 #212.

—
Reply to this email directly or view it on GitHub
#212 (comment).

ADF

[philworthington]

Remove space between class selector and nested selector here.

[philworthington]

This is looking great, I just called out a few small spacing things that are related to our conventions. After that you can just merge this in. Nice updates!