Skip to content
This repository was archived by the owner on May 19, 2023. It is now read-only.

Cleanup some warnings from Clippy #91

Merged
merged 2 commits into from
Jan 14, 2016
Merged

Cleanup some warnings from Clippy #91

merged 2 commits into from
Jan 14, 2016

Conversation

mcarton
Copy link
Contributor

@mcarton mcarton commented Jan 14, 2016

For information, here is the log before and after with Clippy.
Remaining warnings from Clippy are mostly false positive.

@Ogeon
Copy link
Owner

Ogeon commented Jan 14, 2016

Ah, nice! Some, if not many, of those are old relics from when Rust was different... Nice to see them being found and cleaned out. I guess I should start checking with Clippy from time to time.

Some of the remaining ones are most likely necessary or doesn't really matter, but at least the last once about &Vec<...> sounds like it can be safely fixed. I can't imagine a reason for doing like that, except a brain slip. I'm fine with leaving them as they are for now, unless you want to give it another go.

@mcarton
Copy link
Contributor Author

mcarton commented Jan 14, 2016

I wasn't sure about that one since it changes some public interface.

@Ogeon
Copy link
Owner

Ogeon commented Jan 14, 2016

No, that one is safe to change. I have hidden it from the docs and written a warning.

@Ogeon
Copy link
Owner

Ogeon commented Jan 14, 2016

The tests are nice and green. Thank you!

@homu r+

@homu
Copy link
Collaborator

homu commented Jan 14, 2016

📌 Commit 7986f31 has been approved by Ogeon

@homu homu merged commit 7986f31 into Ogeon:master Jan 14, 2016
homu added a commit that referenced this pull request Jan 14, 2016
Cleanup some warnings from Clippy

For information, [here is the log before and after](https://gist.github.com/mcarton/6411c8526dee7b12632b) with Clippy.
Remaining warnings from Clippy are mostly false positive.
@homu
Copy link
Collaborator

homu commented Jan 14, 2016

⚡ Test exempted - status

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants