Skip to content

Conversation

OmarBahamida
Copy link
Owner

  • Closes #xxxx
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

…s/test_solarposition.py

- Deleted the standalone test_solar_angles.py file.
- Added a new test function, test_solar_angles_spring_equinox, to tests/test_solarposition.py.
- The new test verifies solar angles for New York City on the spring equinox, ensuring angles are within expected ranges and follow correct patterns.
@OmarBahamida OmarBahamida merged commit 59d67cf into main Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant