Skip to content

Implement safer solution for testing custom settings #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
iconix opened this issue Sep 19, 2016 · 0 comments
Open

Implement safer solution for testing custom settings #35

iconix opened this issue Sep 19, 2016 · 0 comments
Labels
cleanup

Comments

@iconix
Copy link
Contributor

iconix commented Sep 19, 2016 •
edited
Loading

PR #22 introduced a setSettingsJsonForTesting method in settings.ts in order to allow for testing of custom, non-production settings. However, exposing a test-only method on Settings like this isn't the best approach, as it could get misused.

Get rid of setSettingsJsonForTesting and implement a DI-like solution so that our test environments can inject a different object than the one in the settings.json production file, as desired.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iconix @mttwc