Skip to content

Implement safer solution for testing custom settings #35

Open
@iconix

Description

@iconix

PR #22 introduced a setSettingsJsonForTesting method in settings.ts in order to allow for testing of custom, non-production settings. However, exposing a test-only method on Settings like this isn't the best approach, as it could get misused.

Get rid of setSettingsJsonForTesting and implement a DI-like solution so that our test environments can inject a different object than the one in the settings.json production file, as desired.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions