Skip to content

Conversation

emawby
Copy link
Contributor

@emawby emawby commented Aug 12, 2024

Description

One Line Summary

Fixes an iOS 15 DYLD crash due to not finding ActivityKit

Details

ActivityKit is not available until iOS 16. By putting it in NativeReferences .Net tries to link it even for iOS 15 devices. We do not need to explicitly link it ourselves and can rely on it being there when the app is launched

Motivation

fix crash

Scope

iOS builds on iOS 15 and lower

Testing

Manual testing

tested on iOS 15 simulators

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

@emawby emawby merged commit 8633ad7 into main Aug 13, 2024
1 check passed
@emawby emawby deleted the Fix/iOS_15_crash branch August 13, 2024 17:44
@emawby emawby mentioned this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants