This repository was archived by the owner on Oct 31, 2022. It is now read-only.
Fix jvm memory issue with tests #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkasten2
force-pushed
the
fix/jvm_memory_issue_with_tests
branch
from
fd66e23 to
a90fb05
Compare
jkasten2
force-pushed
the
upgrade/gradle_7.0
branch
from
0d2156f to
c5e3919
Compare
* Theses tests are very slow and memory intivise and need to be run on their own. - Memory issues surfaced when switching to Gradle 7. - Even without this issue it is a good idea to isolate these tests from the rest of the test suite.
* Both test files use assertResults so this was moved into a new file
jkasten2
force-pushed
the
fix/jvm_memory_issue_with_tests
branch
from
a90fb05 to
0ada42b
Compare
jkasten2
changed the title
Jeasmine
approved these changes
Jun 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Updating to Gradle 7.0 (in PR #154) introduced a JVM memory issue in tests. Split up intensive full build tests into its own file which runs on it's own to avoid this.
This change is