Skip to content
This repository was archived by the owner on Oct 31, 2022. It is now read-only.

Conversation

jkasten2
Copy link
Member

@jkasten2 jkasten2 commented Jun 11, 2021

Prefix group with "gradle.plugin"

  • Gradle used to automatically prefix the group id with "gradle.plugin"
    but in the 0.13.0 release this was no longer happening, possibility
    due to upgrading to Gradle 7.
  • This group change caused an issue where the Gradle Plugin Portal
    thought this plugin was being moved to a different group which would
    affect the classpath and requires approval. However this is a breaking
    change we don't want so we have to now pre-fix it ourselves.
  • See the following issue for more context on why this is required now.

This change is Reviewable

jkasten2 added 2 commits June 10, 2021 20:54
* Gradle used to automatically prefix the group id with "gradle.plugin"
but in the 0.13.0 release this was no longer happening, possibility
due to upgrading to Gradle 7.
* This group change caused an issue where the Gradle Plugin Portal
thought this plugin was being moved to a different group which would
affect the classpath and requires approval. However this is a breaking
change we don't want so we have to now pre-fix it ourselves.
* See the following issue for more context on why this is required now.
   - gradle/plugin-portal-requests#103 (comment)
* Confirmed this version works correctly with our plugin
@jkasten2 jkasten2 requested a review from Jeasmine June 11, 2021 04:02
@jkasten2 jkasten2 mentioned this pull request Jun 11, 2021
Base automatically changed from cleanup/dup_meta_properties to main June 11, 2021 17:06
@jkasten2 jkasten2 merged commit 3e1301c into main Jun 11, 2021
@jkasten2 jkasten2 deleted the fix/publish_group_issue branch June 11, 2021 17:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants