This repository was archived by the owner on Oct 31, 2022. It is now read-only.
Pin exact version when in range instead of changing bounds #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When both an exact version and range are defined pin to exact version if in range instead of changing range bounds * Example version '1.5.0' and '[1.0.0, 1.99.99]' will result in '1.5.0' * This does not work in all nested cases yet with gms and android.support for example - "GMS pining when in version range - GMS in sub project - Gradle 4_6" test cases is an example of this issue case
jkasten2
changed the title
* Changed / fixed logic on calculating what version to align to; * Fixed issue where child projects were omitted - Example: main app sets gms:[11.2.0, 11.8.0] & the sub project sets 11.4.0 then 11.4.0 will be use - This was fixed with configuration.copyRecursive() * Now omits version pining for modules under Google's modules. GMS, Firebase, and support. - Uses configuration.incoming.resolutionResult to check the parent to skip - Example gms:play-services-basement:11.2.2 depends on com.android.support:25.2.0 * Added com.android.tools.build:gradle:3.1.0 to build.gradle so IntelliJ can inspect android types
jkasten2
force-pushed
the
version_range_pining
branch
from
dd33241 to
bb732c5
Compare
jkasten2
force-pushed
the
version_range_pining
branch
from
6fe8f8c to
3c03669
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deftoStringwhere they could not be inferred to fix Intellij type checksHistory
Extra debugging dd33241