Fix for privateShowHttpPrompt error with force

[jkasten2]

• Fixes "Cannot read property 'force' of undefined" introduced in 150201
• resolves TypeError: Cannot read property 'force' of undefined #363

---

This change is 

[itrush]

---

Reviewed 2 of 2 files at r1.
Review status: all files reviewed, 1 unresolved discussion (waiting on @jkasten2)

---

test/unit/public-sdk-apis/showHttpPrompt.ts, line 24 at r1 (raw file):

  sinonSandbox.stub(MainHelper, "wasHttpsNativePromptDismissed").resolves(true);
  sinonSandbox.stub(OneSignal, "privateIsPushNotificationsEnabled").resolves(false);

Just a note, not blocking.

Even though this method is called privateIsPushNotificationsEnabled, it's visibility in OneSignal class is default, i.e. public. If it was real private member, you wouldn't be able to stub it. The naming is a bit confusing. We may add a note and refactor it and similar methods in the future.

---

Comments from Reviewable

[jkasten2]

Review status: all files reviewed, 1 unresolved discussion (waiting on @jkasten2)

---

test/unit/public-sdk-apis/showHttpPrompt.ts, line 24 at r1 (raw file):

Previously, itrush (Iryna Trush) wrote…

Just a note, not blocking.

Even though this method is called privateIsPushNotificationsEnabled, it's visibility in OneSignal class is default, i.e. public. If it was real private member, you wouldn't be able to stub it. The naming is a bit confusing. We may add a note and refactor it and similar methods in the future.

@itrush Good catch, there are a few of these so we should clean them all up in another PR

---

Comments from Reviewable