Late setNotificationOpenedHandler call processing

[jkasten2]

Changes

• If OneSignal.setNotificationOpenedHandler is called after
  didFinishLaunchingWithOptions then we still want their handler to fire.
  • So basically the OneSignal SDK will hold onto the event for them
    and fire it as soon as handler is setup.
• This means more flexibility on where / when the developer wants to call
  setNotificationOpenedHandler.
• This is the exact behavior provided in the Android SDK in this commit.
  • OneSignal/OneSignal-Android-SDK@ce5ad7d#diff-2708f86f77e539cab647ecede9d5fcbead3bf0f954d7f9e536eafbc78ba760d6R340-R344
  • ^ To view this click "Load diff" on OneSignalSDK/onesignal/src/main/java/com/onesignal/OneSignal.java

Manual Testing

Tested on iOS 14.2 with the following steps.

1. Send notification to device
2. Swipe away app.
   • To get app into a killed state.
3. Tap on notification.
   • This is a "cold start" thanks to step 2
4. Code setup to call OneSignal.setNotificationOpenedHandler with a delay of 3 seconds

dispatch_after(dispatch_time(DISPATCH_TIME_NOW, 3 * NSEC_PER_SEC), dispatch_get_main_queue(), ^{
    id openNotificationHandler = ^(OSNotificationOpenedResult *result) {
        UIAlertView *alert = [[UIAlertView alloc] initWithTitle:@"Notification Opened Event!" message:@"Notification Opened Event!" delegate:self cancelButtonTitle:@"Close" otherButtonTitles:@"Ok", nil];
        [alert show];
    };
    [OneSignal setNotificationOpenedHandler:openNotificationHandler];
});

5. Wait 3 seconds
6. Confirmed alert dialog showed.

When to merge

• This can be done either before or after the final 3.0.0 release.
• However should be done before any wrapper final releases that depend on 3.0.0.
  • Otherwise wrapper will continue to need to handle this edge case, which is not ideal. Ideal too as we will be retesting this flow as well.

This change is 

[jkasten2]

Test failure is due to log size in TravisCI. I confirmed all tests passed locally.

[Jeasmine]

space after the for 🙏

[jkasten2]

Good catch! I always do that 🤣

[jkasten2]

Created fixup commit 4e0fc0c to address this.

[Jeasmine]

maybe have this addObject in a method, to have the UnprocessedOpenedNotifis mutations centralized?

[jkasten2]

Created fixup commit 4e0fc0c to address this.

[jkasten2]

Ran git rebase -i --autosquash major_release_3.0.0 then git push -f to clean up fixup commit.