fix: Use the postgresml bb8 fork #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
while waiting on djc/bb8#164 to ship
magec
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the postgresml bb8 fork while waiting on djc/bb8#164 to ship.
This may fix potential deadlocks in pgcat when returning a server connection to the bb8 inner pool upon transaction completion.
We've seen a single pgcat pod keeping server connections active for longer than expected across multiple pools. At the same time, the upstream postgres servers didn't show matching active connections suggesting that this pgcat pod was failing to return server connections to their pools when transitioning them from active to idle. Hence leading to the increased client wait time across our shards we experienced as fewer server connections were available.