Skip to content

JSON Schema: Add support for non-string process parameter validation #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
m-mohr opened this issue Jul 9, 2019 · 1 comment
Closed

JSON Schema: Add support for non-string process parameter validation #4

m-mohr opened this issue Jul 9, 2019 · 1 comment
Labels
bug Something isn't working
Milestone
v0.4.x

Comments

@m-mohr
Copy link
Member

m-mohr commented Jul 9, 2019

Currently, ajv can only validate custom formats that have a string data type. This limits validation for epsg-code, temporal-intervals and other formats that are of type array, object or integer. We need to either help improve ajv (see ajv-validator/ajv#1039) or change the processes to use custom JSON schema keywords (see https://github.com/Open-EO/openeo-processes/issues/67). See jsonschema.js for related comments in the code.

Related issue: json-schema-org/json-schema-spec#759
@m-mohr m-mohr added the bug Something isn't working label Jul 9, 2019
@m-mohr m-mohr changed the title Support for non-string validation Support for non-string process validation Jul 9, 2019
@m-mohr m-mohr changed the title Support for non-string process validation JSON Schema: Add support for non-string process parameter validation Jul 9, 2019
@m-mohr m-mohr added this to the v0.4.1 milestone Jul 9, 2019
m-mohr added a commit that referenced this issue Aug 5, 2019
@m-mohr
Fixed JSON schema validation for complex types (#4), v0.4.4
bdf02e7
@m-mohr
Copy link
Member Author

m-mohr commented Aug 5, 2019

Workaround implemented, needs to be removed once https://github.com/Open-EO/openeo-processes/issues/67 is solved.

@m-mohr m-mohr closed this as completed Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.4.x
Development

No branches or pull requests
1 participant
@m-mohr