Skip to content

Permissions issues with PrivateJsonFile on windows #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
soxofaan opened this issue Mar 29, 2021 · 5 comments
Closed

Permissions issues with PrivateJsonFile on windows #198

soxofaan opened this issue Mar 29, 2021 · 5 comments
Assignees
@JohanKJSchreurs
Labels
auth configuration

Comments

@soxofaan
Copy link
Member

Windows does not support fine grained linux style permission chmoding, causing perrmission issues like

File "D:\tmp\env\lib\site-packages\openeo\rest\auth\config.py", line 85, in _write
    assert_private_file(self._path)
  File "D:\tmp\env\lib\site-packages\openeo\rest\auth\config.py", line 30, in assert_private_file
    p=path, a=mode, e=_PRIVATE_PERMS)
PermissionError: File C:\Users\john\AppData\Local\Temp\win-perms-test.json is readable by others: st_mode 100666 (expected permissions: 600).```
soxofaan added a commit that referenced this issue Mar 29, 2021
@soxofaan
Issue #198: only warn about file permissions on windows
56627d6 
`os.chmod` does not change group/other permission on Windows,
so not useful to fail on that at the moment.
@soxofaan
Copy link
Member Author

did a first quick fix to make OIDC at least usable on Windows:
now a warning is raised when permissions are not correctly set

@soxofaan
Copy link
Member Author

next step: investigate oschmod (https://pypi.org/project/oschmod/) to set permissions on windows fully (which does not work with vanilla os.chmod)

@soxofaan soxofaan mentioned this issue Oct 11, 2021
Closed
soxofaan added a commit that referenced this issue Oct 11, 2021
@soxofaan
Issue #198/#249 log.info instead of warn about config file permissi…
ede5fc8 
…ons on Windows
@soxofaan soxofaan added the auth label Oct 11, 2021
@soxofaan
Copy link
Member Author

Also interesting solution: some kind of logout feature to remove these local files: #250

@soxofaan
Copy link
Member Author

FYI failing tests related to this are blocker for

JohanKJSchreurs added a commit that referenced this issue Dec 14, 2022
@JohanKJSchreurs
Issue #198 Use oschmod on Windows to set/get permissions of PrivateJs…
af9f9b3 
…onFile
JohanKJSchreurs added a commit that referenced this issue Dec 14, 2022
@JohanKJSchreurs
Issue #198 Fix bug introduced in previous commit: tests/rest/auth/tes…
e64f576 
…t_config.py:163: AttributeError

AttributeError: 'function' object has no attribute 'st_mode'
JohanKJSchreurs added a commit that referenced this issue Dec 15, 2022
@JohanKJSchreurs
Issue #198 Only install and use oschmod when it is a Windows system.
50c00f2
This was referenced Dec 15, 2022
Closed
Merged
JohanKJSchreurs added a commit that referenced this issue Dec 15, 2022
@JohanKJSchreurs
Issue #198 Code review: simplify and encapsulate getting/setting file…
de07c27 
… permissions.
JohanKJSchreurs added a commit that referenced this issue Dec 15, 2022
@JohanKJSchreurs
Issue #198 Correct regex in test_config.py::test_get_config_verbose
1a1170a
JohanKJSchreurs added a commit that referenced this issue Dec 15, 2022
@JohanKJSchreurs
Issue #198 Code review: make dependency oschmod required on Windows b…
98b9789 
…ut in extra_requires if you want it on another platform
JohanKJSchreurs added a commit that referenced this issue Dec 16, 2022
@JohanKJSchreurs
Issue #198: Updated changelog
14abd88
soxofaan pushed a commit that referenced this issue Jan 4, 2023
@JohanKJSchreurs @soxofaan
Issue #198 Use oschmod on Windows to set/get permissions of PrivateJs…
35af5e2 
…onFile
soxofaan pushed a commit that referenced this issue Jan 4, 2023
@JohanKJSchreurs @soxofaan
Issue #198 Fix bug introduced in previous commit: tests/rest/auth/tes…
b530978 
…t_config.py:163: AttributeError

AttributeError: 'function' object has no attribute 'st_mode'
soxofaan pushed a commit that referenced this issue Jan 4, 2023
@JohanKJSchreurs @soxofaan
Issue #198 Only install and use oschmod when it is a Windows system.
bcceacc
soxofaan pushed a commit that referenced this issue Jan 4, 2023
@JohanKJSchreurs @soxofaan
Issue #198 Code review: simplify and encapsulate getting/setting file…
6d34c4c 
… permissions.
soxofaan pushed a commit that referenced this issue Jan 4, 2023
@JohanKJSchreurs @soxofaan
Issue #198 Correct regex in test_config.py::test_get_config_verbose
14a01dd
soxofaan pushed a commit that referenced this issue Jan 4, 2023
@JohanKJSchreurs @soxofaan
Issue #198 Code review: make dependency oschmod required on Windows b…
7263ea0 
…ut in extra_requires if you want it on another platform
soxofaan pushed a commit that referenced this issue Jan 4, 2023
@JohanKJSchreurs @soxofaan
Issue #198: Updated changelog
1ba0d11
soxofaan added a commit that referenced this issue Jan 4, 2023
@soxofaan
Issue #198 minor finetuning
8f263eb
@soxofaan
Copy link
Member Author

soxofaan commented Jan 4, 2023

PR #351 was merged

@soxofaan soxofaan closed this as completed Jan 4, 2023
@soxofaan soxofaan mentioned this issue Jan 4, 2023
Closed
@soxofaan soxofaan mentioned this issue Jan 4, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JohanKJSchreurs JohanKJSchreurs

Labels
auth configuration
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@soxofaan @JohanKJSchreurs