Remove non-standard srs argument from mask_polygon
#202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geojson as used in `mask_polygon` is EPSG:4326/WGS84 only, openEO API does not provide way to extend this. Implementation in DataCube was non-standard and incomplete (e.g. related to `read_vector` and `Parameter` use cases) related to EP-3747
|
an alternative could be to let the client do the reprojection, but that still has problems: that would introduce new dependency on (e.g.) |
|
Apparently this geojson extension (from 2008 spec, e.g. anyway closing this PR |
|
also see discussion about how to tackle this (ideally) at openEO API level: Open-EO/openeo-processes#235 |
soxofaan
added a commit
that referenced
this pull request
Apr 22, 2021
…egate_spatial` and `mask_polygon` Harmonize geometry handling in `aggregate_spatial` and `mask_polygon`, including handling of non-standard crs and whitelisting of allowed GeoJSON types Raises warning when using a CRS for the geometry of `aggregate_spatial` and `mask_polygon` Also mark this more clearly in the docs Related: #202, Open-EO/openeo-processes#235, Open-EO/openeo-processes#53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
geojson as used in
mask_polygonis EPSG:4326/WGS84 only and openEO API currently does not provide way to extend this.Current implementation in DataCube (and ImageCollectionClient) provides an additional
srsargument to specify an alternative reference system, which is non-standard, not supported by a backend as far as I know .Also the coverage of
srsis incomplete: only the code path that handles a shapely geometry usessrs.Other code paths do not. While it could be possible to add it to the
read_vectoranddictcode paths, it is not possible for theParametercode path without extending the APII would just remove the
srsargument.(related EP-3747, Open-EO/openeo-processes#53)