Skip to content

Improve auto-adding of save_result #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from
Closed

Conversation

soxofaan
Copy link
Member

related to #623, #401, #583, #391

  • Check whole process graph for pre-existing save_result nodes, not just final node
  • Disallow ambiguity of combining explicit save_result and download/create_job with format

@soxofaan
Copy link
Member Author

soxofaan commented Sep 24, 2024

todo:

  • changelog
  • port to vectorcube class too

soxofaan added a commit that referenced this pull request Sep 25, 2024
soxofaan added a commit that referenced this pull request Sep 25, 2024
…583, #391)

Make it more consistent with `download`
@soxofaan soxofaan self-assigned this Sep 25, 2024
@soxofaan soxofaan marked this pull request as ready for review September 25, 2024 10:18
soxofaan added a commit that referenced this pull request Sep 25, 2024
@soxofaan soxofaan force-pushed the issue623-save_result branch from 855a4ca to a032416 Compare September 25, 2024 10:19
soxofaan added a commit that referenced this pull request Sep 25, 2024
…583, #391)

Make it more consistent with `download`
@soxofaan soxofaan closed this Sep 25, 2024
@soxofaan soxofaan force-pushed the issue623-save_result branch from a032416 to 862bfe4 Compare September 25, 2024 10:32
@soxofaan soxofaan deleted the issue623-save_result branch September 25, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant