-
Notifications
You must be signed in to change notification settings - Fork 43
Added acceptable pixel tolerances feature for testing. #777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some quick notes
I'm also not sure we have to use such a cryptic parameter "pxtol". Note that "rtol" and "atol" are just directly adaptations from numpy/array.
This pixel fraction tolerance is however a completely new parameter, so we can be less cryptic, e.g. "pixel_tolerance"
I think it's also important that this feature is covered with unit tests. Are you familiar with pytest and writing tests? |
Yes. I have done it a few times. I will try finding a way to add one. Or will ping you if I need help. |
I have added a simple test to capture all possibilities. Please let me know if I have to add more tests. |
FYI: I merged master in your feature branch, which hopefully fixes the unit test failure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you also add a changelog entry?
I will do it. |
thanks, |
Added a feature mentioned in this issue #776
Feature behavior