aggregate spatial geojson2vectorcube (issue #141) #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soxofaan
commented
Oct 7, 2022
| @@ -161,7 +161,7 @@ def __init__(self, data, format: str = "json", options: dict = None): | |||
| super().__init__(format=format, options=options) | |||
| self.data = data | |||
|
|
|||
| def write_assets(self, path:str) -> Dict[str, StacAsset]: | |||
| def write_assets(self, path: Union[str, Path]) -> Dict[str, StacAsset]: | |||
There was a problem hiding this comment.
path arg name is inconsistent with other write_assets
…tial to VectorCube
…ate_spatial to VectorCube
… aggregate_spatial to VectorCube
…JSON in aggregate_spatial to VectorCube
…ine GeoJSON in aggregate_spatial to VectorCube
soxofaan
force-pushed
the
issue141-aggregate-spatial-geojson2vectorcube
branch
from
73ae035 to
d9d9f90
Compare
|
did some more finetuning, squashing and merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for self-review
issue #141: automatically convert inline geojson in aggregate_spatial to new vector cube implementation