Skip to content

Commit bf618d1

Browse files
authored
Merge pull request #297 from hiddewie/overwrite-move
fix: add overwrite: true to overwrite on existing file
2 parents 68b5d10 + b36d24e commit bf618d1

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

apps/generator-cli/src/app/services/version-manager.service.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -450,7 +450,7 @@ describe('VersionManagerService', () => {
450450
});
451451

452452
it('moves the file to the target location', () => {
453-
expect(fs.moveSync).toHaveBeenNthCalledWith(1, '/tmp/generator-cli-abcDEF/4.2.0', `${fixture.storage}/4.2.0.jar`);
453+
expect(fs.moveSync).toHaveBeenNthCalledWith(1, '/tmp/generator-cli-abcDEF/4.2.0', `${fixture.storage}/4.2.0.jar`, {overwrite: true});
454454
});
455455

456456
it('receives the data piped', () => {

apps/generator-cli/src/app/services/version-manager.service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ export class VersionManagerService {
116116
const file = fs.createWriteStream(temporaryFilePath);
117117
res.data.pipe(file);
118118
file.on('finish', content => {
119-
fs.moveSync(temporaryFilePath, filePath);
119+
fs.moveSync(temporaryFilePath, filePath, {overwrite: true});
120120
resolve(content);
121121
});
122122
})

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@
132132
"ts-jest": "26.5.3",
133133
"ts-node": "9.1.1",
134134
"tslint": "6.1.3",
135-
"type-fest": "0.21.2",
135+
"type-fest": "0.21.3",
136136
"typescript": "4.2.3"
137137
}
138138
}

yarn.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10468,10 +10468,10 @@ [email protected]:
1046810468
resolved "https://registry.yarnpkg.com/type-detect/-/type-detect-4.0.8.tgz#7646fb5f18871cfbb7749e69bd39a6388eb7450c"
1046910469
integrity sha512-0fr/mIH1dlO+x7TlcMy+bIDqKPsw/70tVyeHW787goQjhmqaZe10uwLujubK9q9Lg6Fiho1KUKDYz0Z7k7g5/g==
1047010470

10471-
10472-
version "0.21.2"
10473-
resolved "https://registry.yarnpkg.com/type-fest/-/type-fest-0.21.2.tgz#43b9dc71d9dc5593ea71bf7b0e013ec10f838249"
10474-
integrity sha512-pvQl0WNazvfQ0rq2XDdhpWv49sohh2t+buFbglaJ9N9+Xj4BhFRpuo+uJxemeARteRxRloJ1m+8gBR6Z2Nfktg==
10471+
10472+
version "0.21.3"
10473+
resolved "https://registry.yarnpkg.com/type-fest/-/type-fest-0.21.3.tgz#d260a24b0198436e133fa26a524a6d65fa3b2e37"
10474+
integrity sha512-t0rzBq87m3fVcduHDUFhKmyyX+9eo6WQjZvf51Ea/M0Q7+T374Jp1aUiyUl0GKxp8M/OETVHSDvmkyPgvX+X2w==
1047510475

1047610476
type-fest@^0.11.0:
1047710477
version "0.11.0"

0 commit comments

Comments
 (0)