fix: add overwrite: true to overwrite on existing file #297
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup PR of #295. Concurrent downloads work well, but the filesystem move call throws an error in
fs-extra
when the file already exists... It should replace it of course.Reference documentation: https://github.com/jprichardson/node-fs-extra/blob/master/docs/move-sync.md
Sorry I did not notice it in previous testing. All the tests currently mock the filesystem library, so I cannot simulate an existing file.
Example (anonymized) output of current 2.2.0 version: