Skip to content

Replace HTTP polling from web GUI with Socket.IO #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Replace HTTP polling from web GUI with Socket.IO #109

wants to merge 3 commits into from

Conversation

komppa
Copy link

@komppa komppa commented Sep 29, 2023

  • Removed duplicate script tag from index.html refering to main.js
  • Replaced HTTP polling from web GUI to online_log app with Socket.IO

@WillBeebe
Copy link

Nice work, LGTM

@thinkwee thinkwee self-requested a review October 23, 2023 04:21
ManindraDeMel
ManindraDeMel approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@ManindraDeMel ManindraDeMel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkwee thinkwee Awaiting requested review from thinkwee

1 more reviewer

@ManindraDeMel ManindraDeMel ManindraDeMel approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@komppa @WillBeebe @ManindraDeMel