-
Notifications
You must be signed in to change notification settings - Fork 2
remove hard coded prints #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Indeed I thought about moving from prints to logging but then it has to be done all at once in entire sed. Just was never the highest priority. |
I thought it a good idea to provide feedback on what the processor functions do, in the case of the dataframe operations to give a view on the dataframe shape after their action. You can also specify preview=True to see the head of the df. What is it you don't like about it? |
It should be straightforward to go from print("") to logging.info(""), can i just go ahead and do this? |
I think in general logging is the right way to go. print statements are rather rudimentary approach. With logging, we can even have logs for debugging as well. And allow users to set the verbose level as well @rettigl |
Logging is a great idea, I am a huge fan! But its not as straight forward as changing print to This could even add a nice feature of tracking a history of all we are doing to the metadata, additional to our current method tracking. |
Is your feature request related to a problem? Please describe.
Cell output sometimes gets spammed with hard coded prints, for example in the append_energy_axis function.
Describe the solution you'd like
I would like for such prints to be implemented using the logging module
Describe alternatives you've considered
I have considered the possibility of removing such prints, or suppressing prints by using
and then
but neither of these solutions is ideal, compared to the logging module solution
Additional context
The text was updated successfully, but these errors were encountered: