Skip to content

Reduce Verbosity #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2023
Merged

Reduce Verbosity #248

merged 1 commit into from
Nov 9, 2023

Conversation

steinnymir
Copy link
Member

@steinnymir steinnymir commented Nov 7, 2023 •
edited
Loading

add a verbose option to the SedProcessor init, which toggles printing the dataframe after the calibration steps.

This is a simple and straight forward PR, I hope we can merge it quickly.

It closes #177 by solving the problem in a simple way.
The option of using logging will be moved to a new issue.

@steinnymir steinnymir changed the title Update build_deploy_docs.yml Reduce Verbosity Nov 7, 2023
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 6783324305

  • 6 of 11 (54.55%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 90.677%
Changes Missing Coverage Covered Lines Changed/Added Lines %
sed/core/processor.py 6 11 54.55%
Totals Coverage Status
Change from base Build 6776802063: 0.01%
Covered Lines: 4902
Relevant Lines: 5406
💛 - Coveralls

@steinnymir steinnymir mentioned this pull request Nov 7, 2023
Closed
rettigl
rettigl approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@rettigl rettigl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You could add respective reporting code also in the functions that don't have it yet (e.g. energy shift, tof_ns axis), but also not so important.

@steinnymir steinnymir merged commit e4d473d into main Nov 9, 2023
@steinnymir steinnymir deleted the reduce_verbosity branch November 9, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rettigl rettigl rettigl approved these changes

@balerion balerion Awaiting requested review from balerion

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove hard coded prints
3 participants
@steinnymir @coveralls @rettigl