Skip to content

Workflow restructuring #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 11, 2023
Merged

Workflow restructuring #166

merged 4 commits into from
Oct 11, 2023

Conversation

rettigl
Copy link
Member

@rettigl rettigl commented Oct 9, 2023

As discussed:

  • run all-versions tests only on push to main (pull-request merges)
  • speed up tests by omitting multiple calculations of inverse dfields in metadata tests

@rettigl
Copy link
Member Author

rettigl commented Oct 9, 2023

Disadvantage is: We apparently don't get the coveralls reports if we don't do pull-request builds...

@coveralls
Copy link
Collaborator

coveralls commented Oct 9, 2023

Pull Request Test Coverage Report for Build 6483750068

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 90.479%

Files with Coverage Reduction New Missed Lines %
sed/calibrator/energy.py 2 91.86%
sed/binning/numba_bin.py 3 87.74%
Totals Coverage Status
Change from base Build 6471550709: -0.1%
Covered Lines: 4286
Relevant Lines: 4737

💛 - Coveralls

@zain-sohail
Copy link
Member

Looks good. Definitely faster now.
I will look into caching the installation of the package as that is mostly same. Would save another 2 mins.
And you said the other slowdown was downloading data for tests right? Maybe we can also cache that, or use a smaller set?

@rettigl
Copy link
Member Author

rettigl commented Oct 9, 2023

Looks good. Definitely faster now. I will look into caching the installation of the package as that is mostly same. Would save another 2 mins. And you said the other slowdown was downloading data for tests right? Maybe we can also cache that, or use a smaller set?

That was related to the notebook conversion. I suppose we don't do this often.

@zain-sohail
Copy link
Member

Looks good. Definitely faster now. I will look into caching the installation of the package as that is mostly same. Would save another 2 mins. And you said the other slowdown was downloading data for tests right? Maybe we can also cache that, or use a smaller set?

That was related to the notebook conversion. I suppose we don't do this often.

Right. I am not sure if the github workers can actually process the notebooks. I will try that and see. Otherwise, we would have to do it locally or our own runner (possible to set this up now).

I will merge this PR and update a few workflows afterwards.

@zain-sohail zain-sohail merged commit ec5bccd into main Oct 11, 2023
@zain-sohail zain-sohail deleted the workflow_restructuring branch October 11, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants