Skip to content

Fix to release workflow #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 21, 2023
Merged

Fix to release workflow #291

merged 4 commits into from
Nov 21, 2023

Conversation

zain-sohail
Copy link
Member

In reference to #285

Some comments in #280 are also addressed here

@coveralls
Copy link
Collaborator

coveralls commented Nov 21, 2023

Pull Request Test Coverage Report for Build 6943253162

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.586%

Totals Coverage Status
Change from base Build 6942939676: 0.0%
Covered Lines: 5562
Relevant Lines: 6140

💛 - Coveralls

@zain-sohail zain-sohail requested a review from rettigl November 21, 2023 10:27
Copy link
Member

@rettigl rettigl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can try it out, not sure I understand if it should work or not.

@rettigl rettigl merged commit 8cc1c1a into main Nov 21, 2023
@rettigl rettigl deleted the automation-improvements branch November 21, 2023 14:25
@rettigl
Copy link
Member

rettigl commented Nov 21, 2023

Did not work, was it because the version was out of date with pipy?
I'd suggest to make a new main release 1.6, how do I do that?

@zain-sohail
Copy link
Member Author

Did not work, was it because the version was out of date with pipy? I'd suggest to make a new main release 1.6, how do I do that?

It's because last time the publish job worked but the bump version job didn't. So next time the bump job would be a version behind. Easy fix is to just bump the version once manually.

git tag v0.1.6 and pushing the tag will trigger the workflow to update to version 0.1.6

@zain-sohail zain-sohail restored the automation-improvements branch November 21, 2023 14:53
@rettigl
Copy link
Member

rettigl commented Nov 21, 2023

Still not working

@zain-sohail
Copy link
Member Author

zain-sohail commented Nov 21, 2023

Still not working

Fixed now.
I also included should include paths-ignore pyproject.toml to all workflows since otherwise they will execute twice for no reason. Once for actual PR and once after bumping version.

@rettigl
Copy link
Member

rettigl commented Nov 21, 2023

Thanks, great. Also great development guide. Do we have some mechanism to restrict anyone from creating new releases?
When I pushed my created tag, it pushed all kind of tags with version numbers >0.2, no idea where they came from. Can you clean that up?

@zain-sohail
Copy link
Member Author

Thanks, great. Also great development guide.

Thanks. Also thinking to extend for general contributions but also great if we extend it for developing loaders, as an API reference is clearly not enough.

Do we have some mechanism to restrict anyone from creating new releases?

Ok just added v* to protected tags. But currently, it's just a very few of us with write access to the repo. But still a good idea.

Do we have some mechanism to restrict anyone from creating new releases? When I pushed my created tag, it pushed all kind of tags with version numbers >0.2, no idea where they came from. Can you clean that up?

The other versions were my tests on testpypi. You can see those are from a few days ago. I will remove them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants