-
Notifications
You must be signed in to change notification settings - Fork 2
Fix to release workflow #291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 6943253162
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can try it out, not sure I understand if it should work or not.
Did not work, was it because the version was out of date with pipy? |
It's because last time the publish job worked but the bump version job didn't. So next time the bump job would be a version behind. Easy fix is to just bump the version once manually. git tag v0.1.6 and pushing the tag will trigger the workflow to update to version 0.1.6 |
Still not working |
Fixed now. |
Thanks, great. Also great development guide. Do we have some mechanism to restrict anyone from creating new releases? |
Thanks. Also thinking to extend for general contributions but also great if we extend it for developing loaders, as an API reference is clearly not enough.
Ok just added v* to protected tags. But currently, it's just a very few of us with write access to the repo. But still a good idea.
The other versions were my tests on testpypi. You can see those are from a few days ago. I will remove them |
In reference to #285
Some comments in #280 are also addressed here