Skip to content

Tof binning as actual binning values #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 8, 2024

Conversation

rettigl
Copy link
Member

@rettigl rettigl commented Jun 27, 2024

This changes the config behavior of tof_binning and adc_binning, as well as the config location of "num_cores"

closing #173
closing #404

@coveralls
Copy link
Collaborator

coveralls commented Jun 27, 2024

Pull Request Test Coverage Report for Build 9701919094

Details

  • 19 of 20 (95.0%) changed or added relevant lines in 5 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 91.82%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sed/core/processor.py 5 6 83.33%
Files with Coverage Reduction New Missed Lines %
sed/binning/numba_bin.py 3 87.5%
Totals Coverage Status
Change from base Build 9680494155: -0.04%
Covered Lines: 6432
Relevant Lines: 7005

💛 - Coveralls

@rettigl rettigl force-pushed the tof_binning-as-actual-binning-values branch from a421004 to fa094c6 Compare June 27, 2024 18:48
@rettigl rettigl requested a review from zain-sohail June 27, 2024 18:48
@coveralls
Copy link
Collaborator

coveralls commented Jun 27, 2024

Pull Request Test Coverage Report for Build 9702009313

Details

  • 19 of 20 (95.0%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 91.849%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sed/core/processor.py 5 6 83.33%
Files with Coverage Reduction New Missed Lines %
sed/binning/numba_bin.py 1 89.42%
Totals Coverage Status
Change from base Build 9680494155: -0.01%
Covered Lines: 6434
Relevant Lines: 7005

💛 - Coveralls

This was referenced Jun 27, 2024
@coveralls
Copy link
Collaborator

coveralls commented Jun 30, 2024

Pull Request Test Coverage Report for Build 9733958219

Details

  • 19 of 20 (95.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 92.465%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sed/core/processor.py 5 6 83.33%
Totals Coverage Status
Change from base Build 9733946272: 0.003%
Covered Lines: 6872
Relevant Lines: 7432

💛 - Coveralls

@rettigl rettigl force-pushed the tof_binning-as-actual-binning-values branch from 708a9c1 to 0da2561 Compare July 2, 2024 07:43
@coveralls
Copy link
Collaborator

coveralls commented Jul 2, 2024

Pull Request Test Coverage Report for Build 9756941681

Details

  • 19 of 20 (95.0%) changed or added relevant lines in 5 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 92.425%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sed/core/processor.py 5 6 83.33%
Files with Coverage Reduction New Missed Lines %
sed/binning/numba_bin.py 3 87.5%
Totals Coverage Status
Change from base Build 9756916343: -0.04%
Covered Lines: 6869
Relevant Lines: 7432

💛 - Coveralls

@zain-sohail zain-sohail mentioned this pull request Jul 2, 2024
11 tasks
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 9837247580

Details

  • 19 of 20 (95.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 92.472%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sed/core/processor.py 5 6 83.33%
Totals Coverage Status
Change from base Build 9837233931: 0.04%
Covered Lines: 6879
Relevant Lines: 7439

💛 - Coveralls

Copy link
Member

@zain-sohail zain-sohail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rettigl rettigl merged commit ecd517d into v1_feature_branch Jul 8, 2024
5 checks passed
@rettigl rettigl deleted the tof_binning-as-actual-binning-values branch July 8, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move n_cores out of binning and into core tof_binning as actual binning values
3 participants