Skip to content

Logging #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 19, 2024
Merged

Logging #490

merged 11 commits into from
Sep 19, 2024

Conversation

rettigl
Copy link
Member

@rettigl rettigl commented Aug 13, 2024

This PR converts all output into logger entries.
It also adds a call logger to record all function calls on the main workflow functions in the processor class

@coveralls
Copy link
Collaborator

coveralls commented Aug 13, 2024

Pull Request Test Coverage Report for Build 10948948523

Details

  • 283 of 341 (82.99%) changed or added relevant lines in 12 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 92.522%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sed/core/logging.py 36 37 97.3%
sed/loader/base/loader.py 5 7 71.43%
sed/calibrator/delay.py 25 28 89.29%
sed/loader/flash/loader.py 10 13 76.92%
sed/loader/sxp/loader.py 10 13 76.92%
sed/calibrator/momentum.py 36 40 90.0%
sed/calibrator/energy.py 36 44 81.82%
sed/core/processor.py 87 104 83.65%
sed/loader/mpes/loader.py 23 40 57.5%
Files with Coverage Reduction New Missed Lines %
sed/calibrator/energy.py 1 92.6%
Totals Coverage Status
Change from base Build 10948927564: -0.2%
Covered Lines: 7238
Relevant Lines: 7823

💛 - Coveralls

This was referenced Aug 14, 2024
@rettigl rettigl force-pushed the logging branch 2 times, most recently from b3328cd to 82ce3f2 Compare August 14, 2024 07:44
Copy link
Member

@zain-sohail zain-sohail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge. Perhaps the comments I mentioned can be looked at, or can be done at another time.

@rettigl rettigl merged commit c90e839 into v1_feature_branch Sep 19, 2024
5 checks passed
@rettigl rettigl deleted the logging branch September 19, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants