Skip to content

Bug 12 places #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion server.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import json
from datetime import datetime
from flask import Flask,render_template,request,redirect,flash,url_for


Expand Down Expand Up @@ -46,8 +47,18 @@ def purchasePlaces():
competition = [c for c in competitions if c['name'] == request.form['competition']][0]
club = [c for c in clubs if c['name'] == request.form['club']][0]
placesRequired = int(request.form['places'])
competition['numberOfPlaces'] = int(competition['numberOfPlaces'])-placesRequired
if placesRequired > 12:
flash("you can not book more than 12 places")
return render_template('welcome.html', club=club, competitions=competitions)
if datetime.strptime(competition['date'], "%Y-%m-%d %H:%M:%S") < datetime.now():
flash("You cannot book place in past competition")
return render_template('welcome.html', club=club, competitions=competitions)
if placesRequired > int(club["points"]):
flash("you can not book more than available points")
return render_template('welcome.html', club=club, competitions=competitions)
competition['numberOfPlaces'] = int(competition['numberOfPlaces']) - placesRequired
flash('Great-booking complete!')
club["points"] = int(club["points"]) - placesRequired
return render_template('welcome.html', club=club, competitions=competitions)


Expand Down
2 changes: 1 addition & 1 deletion templates/booking.html
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ <h2>{{competition['name']}}</h2>
<form action="/purchasePlaces" method="post">
<input type="hidden" name="club" value="{{club['name']}}">
<input type="hidden" name="competition" value="{{competition['name']}}">
<label for="places">How many places?</label><input type="number" name="places" id=""/>
<label for="places">How many places?</label><input type="number" min="0" max="{{club['points']}}" name="places" id=""/>
<button type="submit">Book</button>
</form>
</body>
Expand Down
109 changes: 109 additions & 0 deletions test/tests_unitaires/test_server.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,109 @@
import pytest
from server import app
from datetime import datetime, timedelta


@pytest.fixture
def client():
app.config['TESTING'] = True
app.secret_key = "test"
with app.test_client() as client:
yield client


def test_booking_past_competition(client, monkeypatch):
# Compétition passée (hier)
past_date = (datetime.now() - timedelta(days=1)).strftime("%Y-%m-%d %H:%M:%S")
test_competition = {"name": "Past Competition", "numberOfPlaces": "10", "date": past_date}
test_club = {"name": "Test Club", "email": "[email protected]", "points": "15"}
monkeypatch.setattr("server.clubs", [test_club])
monkeypatch.setattr("server.competitions", [test_competition])

response = client.post("/purchasePlaces", data={
"competition": "Past Competition",
"club": "Test Club",
"places": "2"
}, follow_redirects=True)

# Vérifie que le message d'erreur apparaît
assert b"You cannot book place in past competition" in response.data

# Vérifie que les places n'ont pas été modifiées
assert test_competition["numberOfPlaces"] == "10"

# Vérifie que les points du club n'ont pas changé
assert test_club["points"] == "15"


def test_booking_more_than_12_places(client, monkeypatch):
test_club = {"name": "Test Club", "email": "[email protected]", "points": "50"}
test_competition = {"name": "Test Competition", "numberOfPlaces": "25", "date": "2025-12-12 10:00:00"}
monkeypatch.setattr("server.clubs", [test_club])
monkeypatch.setattr("server.competitions", [test_competition])

response = client.post("/purchasePlaces", data={
"competition": "Test Competition",
"club": "Test Club",
"places": "13" # > 12 → doit déclencher le bloc
}, follow_redirects=True)

# Vérifie que le message flash est bien là
assert b"you can not book more than 12 places" in response.data
# Vérifie que les données n'ont pas été modifiées
assert test_competition["numberOfPlaces"] == "25"
assert test_club["points"] == "50"


def test_competition_places_are_decreased(client, monkeypatch):
# Club avec assez de points
test_club = {"name": "Test Club", "email": "[email protected]", "points": "20"}
# Compétition avec 10 places
test_competition = {"name": "Test Competition", "numberOfPlaces": "10", "date": "2025-12-12 10:00:00"}

# Patch les données directement dans server.py
monkeypatch.setattr("server.clubs", [test_club])
monkeypatch.setattr("server.competitions", [test_competition])

# POST de réservation de 3 places
response = client.post("/purchasePlaces", data={
"competition": "Test Competition",
"club": "Test Club",
"places": "3"
}, follow_redirects=True)

# Vérifie que la compétition a bien été mise à jour
assert test_competition["numberOfPlaces"] == 7 # 10 - 3

def test_purchase_places_more_than_points(client, monkeypatch):
# Simuler un club avec seulement 2 points
test_club = {"name": "Test Club", "email": "[email protected]", "points": "2"}
test_competition = {"name": "Test Competition", "numberOfPlaces": "10", "date": "2025-12-12 10:00:00"}

# Patch les données dans server.py
monkeypatch.setattr("server.clubs", [test_club])
monkeypatch.setattr("server.competitions", [test_competition])

# Envoyer un formulaire avec 5 places (plus que les 2 points disponibles)
response = client.post("/purchasePlaces", data={
"competition": "Test Competition",
"club": "Test Club",
"places": "5"
}, follow_redirects=True)

# Vérifier que le message d'erreur s'affiche
assert b"you can not book more than available points" in response.data

def test_purchase_places_success(client, monkeypatch):
test_club = {"name": "Test Club", "email": "[email protected]", "points": "10"}
test_competition = {"name": "Test Competition", "numberOfPlaces": "15", "date": "2025-12-12 10:00:00"}

monkeypatch.setattr("server.clubs", [test_club])
monkeypatch.setattr("server.competitions", [test_competition])

response = client.post("/purchasePlaces", data={
"competition": "Test Competition",
"club": "Test Club",
"places": "3"
}, follow_redirects=True)

assert b"Great-booking complete!" in response.data