Skip to content

Make Behat tests Symfony 4 proof #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Make Behat tests Symfony 4 proof #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38a1726
Change SF4 default env based on dev group_names
MKodde Mar 4, 2021
603c1b0
Make FeatureContext SF4 proof
MKodde Mar 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions roles/app/templates/php72-nginx-vhost-symfony4.conf.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,24 @@ server {
include fastcgi_params;
fastcgi_param SCRIPT_FILENAME $document_root$fastcgi_script_name;
fastcgi_param HTTPS on;
fastcgi_param SYMFONY_ENV prod;
fastcgi_param APP_ENV prod;

{% if 'dev' not in group_names %}
# Non dev environments have the symfony env set to prod in a hardcoded manner
set $app_env "prod";
set $app_debug false;
{% elif 'dev' in group_names %}
# If the testcookie is present, we will kick the symfony environment into smoketest mode. Otherwise dev mode it is.
set $app_env "dev";
set $app_debug true;
if ($cookie_testcookie) {
set $app_env "smoketest";
set $app_debug true;
}
{% endif %}

fastcgi_param SYMFONY_ENV $app_env;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would opt to hardcode this for production

fastcgi_param APP_ENV $app_env;
fastcgi_param APP_DEBUG $app_debug;
}

{# Finally, disallow opening php files outside of index.php #}
Expand Down
10 changes: 5 additions & 5 deletions tests/behat/features/bootstrap/FeatureContext.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,16 +51,16 @@ public static function setupDatabase(BeforeFeatureScope $scope)
{
// Generate test databases
echo "Preparing test schemas\n";
shell_exec("/src/Stepup-Middleware/app/console doctrine:schema:drop --env=smoketest --force");
shell_exec("/src/Stepup-Gateway/app/console doctrine:schema:drop --env=test --force");
shell_exec("/src/Stepup-Middleware/app/console doctrine:schema:create --env=smoketest");
shell_exec("/src/Stepup-Gateway/app/console doctrine:schema:create --env=test");
shell_exec("php72 /src/Stepup-Middleware/bin/console doctrine:schema:drop --env=smoketest --force");
shell_exec("php72 /src/Stepup-Gateway/bin/console doctrine:schema:drop --env=test --force");
shell_exec("php72 /src/Stepup-Middleware/bin/console doctrine:schema:create --env=smoketest");
shell_exec("php72 /src/Stepup-Gateway/bin/console doctrine:schema:create --env=test");

echo "Replaying event stream\n";
// Import the events.sql into middleware
shell_exec("mysql -uroot -ppassword middleware_test < ./fixtures/events.sql");
// Perform an event replay
shell_exec("/src/Stepup-Middleware/app/console middleware:event:replay --env=smoketest_event_replay --no-interaction -q");
shell_exec("php72 /src/Stepup-Middleware/bin/console middleware:event:replay --env=smoketest_event_replay --no-interaction -q");

echo "Update the keys\n";
// Update the `saml_entities` projection in `gateway_test`
Expand Down