[PATCH v2] test: bench_timer: add tests for timer start and cancel #2263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odpbuild
changed the title
MatiasElo
reviewed
Oct 2, 2025
test/performance/odp_bench_timer.c
Outdated
| return 0; | ||
| } | ||
|
|
||
| static void init_suite(gbl_args_t *gbl_args, odp_bool_t is_export) |
There was a problem hiding this comment.
is_export seems kinda unnecessary, the result pointer could be initialized always.
Add new option to control measurement mode. Two modes are provided, one for throughput and one for latency. Throughput mode keeps track of average execution times and is basically the current operation mode of the tester. Latency mode utilizes the bench tm suite and additionally tracks function minimum and maximum execution times. Signed-off-by: Tuomas Taipale <[email protected]>
Add new tests for (oneshot) timer start and cancel. Signed-off-by: Tuomas Taipale <[email protected]>
TuomasTaipale
force-pushed
the
dev/refactor_bench_timer
branch
from
4a3dc65 to
422a5da
Compare
odpbuild
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new tests for (oneshot) timer start and cancel. Additionally, add new mode option for optionally tracking function minimum and maximum on top of average execution times.
v2: