Changes on FAST Farm case creation pull request #66

MYMahfouz · 2023-06-21T22:44:05Z

I have used the pull request #56 as a basis and updated it to include the following:

Windows batch files.
Accept .dll controllers
Create Mann turbulent boxes that are used in the simulation.
Added a floating flag to include HydroDyn and MoorDyn.

I am planning to make more changes to include:

Fast Farm batch files including an option for OMP.
Option to add intial condition according to the wind direction and wind speed.
Adding wave height and Tp to the case creation.

I hope this helps. Thanks for creating the library.

BR,
Youssef

Function to create a bat file for the Mann box and execute it

Adding functions to create the fstf file from Mann Box. creating functions to create and execute .bat files for TurbSim. Adding floating flag as well as Mooring files and rotating the mooring system with the wind direction. Adding the option to have a different Hydrodyn file for each turbine which is needed for floating wind turbines. There are also some other minor changes.

Changes in example 3 to reflect the added functions

I have made all turbines be on the positive side of the x-axis because for the MannBox this is necessary. I have modified TurbSim functions to follow the same.

update shifting the turbines to do the same function if the minimum x-coordinate is higher than zero

ebranlard

Thanks for doing that and sharing. I've added a couple of comments that it would be great to address. Sorry for the extra work!

pyFAST/fastfarm/FASTFarmCaseCreation.py

pyFAST/fastfarm/examples/Ex3_FFarmCompleteSetup.py

pyFAST/fastfarm/MannCaseCreation.py

adding _repr_ function

added a flag for executing MannBox .bat file.

rthedin · 2023-06-22T17:20:57Z

Hi Youssef-- Thanks for re-submitting the PR. There are a lot of changes here. I will provide detailed comments, but I will also open a discussion so we can talk about your needs and how incorporate the Mann box without modifying defaults. It is imperative that the changes are backward compatible. Let's iterate more about the changes before we pull everything in. Smaller commits with meaningful commit messages (and separate PRs) make everyone's life easier. For instance, all the formatting changes (like removing the f-strings) can/should be done in a separate commit, ideally a separate PR.

changing ex3 to the former version with only adding the new changes

MYMahfouz · 2023-06-22T17:45:14Z

Hi @rthedin ,
I am sorry I wasn't really keeping track of the changes. I did my best not to do any big changes to the code that was already there.

I believe there are two major changes:

The way I rotate the turbines in the _rotate_wts.
I stopped using the symlink as it was causing some errors and I copied the Low.bts file instead. This is however not a problem using the MannBox as only one wind field is used.

I am sorry for the mess and the big changes, I am willing to help and adjust as needed. However, I cannot redo everything step by step and recommit as this will be very time consuming.
Again thanks a lot for creating this code as it is super helpful.

Just one question. I never managed to run FASTFarm with Mod_AmbWind=3, did you run it successfully?

BR,
Youssef

rthedin

Apologies for the amount of comments. Let's move this to a discussion and iterate how to properly integrate the Mann boxes and your workflow into the toolbox.

rthedin · 2023-06-22T17:21:24Z

pyFAST/fastfarm/FASTFarmCaseCreation.py

-                 nSeeds = 6,
+                 nSeeds = 1,


The default number of seeds follow the IEC 61400 standard. If you need to run only one seed for the Mann boxes, then you can specify nSeeds=1 without the need to change the defaults

agreed I was just making it easier for myself but you are correct.

rthedin · 2023-06-22T17:21:47Z

pyFAST/fastfarm/FASTFarmCaseCreation.py

                 seedValues = None,
                 LESpath = None,
                 sweepWakeSteering = False,
                 sweepYawMisalignment = False,
                 refTurb_rot = 0,
-                 verbose = 0):
+                 verbose = 0,
+                 floating=0):


This is certainly a good option to have!

rthedin · 2023-06-22T17:23:45Z

pyFAST/fastfarm/FASTFarmCaseCreation.py

-            Max simulation time given in seconds
+            Wind field time given in seconds
+        tsim: integer
+            Multiple of tmax to repeat the wind field


This seems to be something that only applied to the Mann box? I'm not sure as I haven't used Mann extensively. Changing the description of tmax to "wind field time [...]` is misleading because this also the time used on FAST.Farm.

This is also an option in TurbSim. Your simulation time can be multiple of your windfield time, this way you do not create big windfields.

rthedin · 2023-06-22T17:24:25Z

pyFAST/fastfarm/FASTFarmCaseCreation.py

        LESpath: str or list of strings
-            Full path of the LES data, if driven by LES. If None, the setup will be for TurbSim inflow.
+            Full path of the LES data, if driven by LES. 
+            If TurbSim, the setup will be for TurbSim inflow.
+            If MannBox, the setup will be for MannBox inflow.


Okay, I see a need for a different option if now we have TurbSim, Mann, and LES. This needs to be changed.

rthedin · 2023-06-22T17:24:53Z

pyFAST/fastfarm/FASTFarmCaseCreation.py

+        self.TurbSimbin  = TurbSimbin
+        self.Mannbin     = Mannbin


Good point. This is useful to have.

rthedin · 2023-06-22T17:47:15Z

pyFAST/fastfarm/FASTFarmCaseCreation.py

-                    if self.mod_wake == 1: # Polar model
-                        self.dr = self.cmax
-                    else: # Curled; Cartesian
-                        self.dr = round(self.D/10)
+                    # if self.mod_wake == 1: # Polar model
+                    #     self.dr = self.cmax
+                    # else: # Curled; Cartesian
+                    #     self.dr = round(self.D/10)


Is there a reason to remove this?

yes. The dr should be same as DX and this is not necessarily the same as self.cmax

rthedin · 2023-06-22T17:47:49Z

pyFAST/fastfarm/FASTFarmCaseCreation.py

                    print(f'Calling: {sub_command}')
                    _ = subprocess.call(sub_command, cwd=self.path, shell=True)
                    time.sleep(delay) # Sometimes the same job gets submitted twice. This gets around it.


+    def Create_Mannbox(self, Lm, gamma):


Thanks for creating this function. It is a really good capability to add to this case generation tool.

rthedin · 2023-06-22T17:48:51Z

pyFAST/fastfarm/FASTFarmCaseCreation.py

+                        if nx == None:
+                            nx=re.search('Nx :(\d+)', lines[i])
+                        if dx == None:
+                            dx=re.search('Dx : ((?:0|[1-9]\d*)(\.\d*)?(?:[eE][+\-]?\d+))', lines[i])
+                        if ny == None:
+                            ny=re.search('Ny :(\d+)', lines[i])
+                        if dy == None:
+                            dy=re.search('Dy : ((?:0|[1-9]\d*)(\.\d*)?(?:[eE][+\-]?\d+))', lines[i])
+                        if nz == None:
+                            nz=re.search('Nz :(\d+)', lines[i])
+                        if dz == None:
+                            dz=re.search('Dz : ((?:0|[1-9]\d*)(\.\d*)?(?:[eE][+\-]?\d+))', lines[i])               


Regex like this should come with some comments above. It is hard to tell what is being done here.

I am reading the parameters of the MannBox as they have to be identical to the parameters in the Inflowind.dat file

rthedin · 2023-06-22T17:50:48Z

pyFAST/fastfarm/examples/Ex3_FFarmCompleteSetup.py

-    slurm_TS_high           = './SampleFiles/runAllHighBox.sh'
-    slurm_TS_low            = './SampleFiles/runAllLowBox.sh'
-    slurm_FF_single         = './SampleFiles/runFASTFarm_cond0_case0_seed0.sh'
+    slurm_TS_high           = '\SampleFiles/runAllHighBox.sh'
+    slurm_TS_low            = '/runAllLowBox.sh'
+    slurm_FF_single         = '/runFASTFarm_cond0_case0_seed0.sh'


I see how I left the / here for *nix systems and should have used os.path.join instead. But by changing this to the Windows convention, you break its use. This needs to be updated to a more generic approach (e.g. using os)

yes I agree

rthedin · 2023-06-22T17:51:55Z

pyFAST/fastfarm/FASTFarmCaseCreation.py

-                    self.ServoDynFile['DLL_FileName'] = f'"{self.DLLfilepath}{t+1}.so"'
+                    self.ServoDynFile['DLL_FileName'] = f'"{self.DLLfilepath}{t+1}.dll"'


so are used in *nix and dll in Windows. We need to identify what system the user is using or not specify the extension.

yes I agree

MYMahfouz · 2023-06-22T18:15:12Z

@rthedin no worries. I have replied to all the comments.

BR,
Youssef

added batch files for turbsim and mannbox

rthedin · 2023-06-23T19:32:56Z

Closing this and moving it to a discussion: #67.

MYMahfouz added 5 commits June 21, 2023 16:31

Create MannCaseCreation.py

6ddb5bb

Function to create a bat file for the Mann box and execute it

Update Ex3_FFarmCompleteSetup.py

9ecd244

Changes in example 3 to reflect the added functions

Update FASTFarmCaseCreation.py

ecb5ae1

I have made all turbines be on the positive side of the x-axis because for the MannBox this is necessary. I have modified TurbSim functions to follow the same.

Update FASTFarmCaseCreation.py

c89fab5

update shifting the turbines to do the same function if the minimum x-coordinate is higher than zero

ebranlard suggested changes Jun 22, 2023

View reviewed changes

pyFAST/fastfarm/FASTFarmCaseCreation.py Show resolved Hide resolved

pyFAST/fastfarm/examples/Ex3_FFarmCompleteSetup.py Outdated Show resolved Hide resolved

pyFAST/fastfarm/MannCaseCreation.py Outdated Show resolved Hide resolved

ebranlard added the case generation label Jun 22, 2023

ebranlard requested a review from rthedin June 22, 2023 16:51

MYMahfouz added 2 commits June 22, 2023 11:02

Update FASTFarmCaseCreation.py

f8e3a92

adding _repr_ function

execute Mannbox flag

2c26291

added a flag for executing MannBox .bat file.

Update Ex3_FFarmCompleteSetup.py

8ed3704

changing ex3 to the former version with only adding the new changes

rthedin reviewed Jun 22, 2023

View reviewed changes

batch files

985fcc8

added batch files for turbsim and mannbox

rthedin closed this Jun 23, 2023

This was referenced Jun 28, 2024

Further improvements and bug fixes to FAST.Farm case generation OpenFAST/openfast_toolbox#15

Merged

Ongoing list of improvements/issues/bugs on FAST.Farm case setup OpenFAST/openfast_toolbox#17

Open

		self.ServoDynFile['DLL_FileName'] = f'"{self.DLLfilepath}{t+1}.so"'
		self.ServoDynFile['DLL_FileName'] = f'"{self.DLLfilepath}{t+1}.dll"'

Changes on FAST Farm case creation pull request #66

Changes on FAST Farm case creation pull request #66

Uh oh!

Conversation

MYMahfouz commented Jun 21, 2023

Uh oh!

ebranlard left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rthedin commented Jun 22, 2023

Uh oh!

MYMahfouz commented Jun 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rthedin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MYMahfouz commented Jun 22, 2023

Uh oh!

rthedin commented Jun 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MYMahfouz commented Jun 22, 2023 •

edited

Loading