Add constructor to RetryableException for cases without retryAfter #2871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rojae
force-pushed
the
fix/2458-retryableexception-add-simple-constructor
branch
2 times, most recently
from
31d0395 to
752db82
Compare
|
Force-pushed to simplify the commit history and correct unintended changes caused by formatting. |
velo
approved these changes
May 5, 2025
auto-merge was automatically disabled
May 7, 2025 18:50
Head branch was pushed to by a user without write access
- A constructor without retryAfter and without cause - A constructor without retryAfter but with cause Standardized JavaDoc across all RetryableException constructors These new constructors remove overload ambiguity when retryAfter is not needed. Add. a unit test to verify the new constructors. - canCreateRetryableExceptionWithoutRetryAfter - canCreateRetryableExceptionWithoutRetryAfterAndWithCause Fixes OpenFeign#2458
rojae
force-pushed
the
fix/2458-retryableexception-add-simple-constructor
branch
from
5423711 to
9c3bedf
Compare
|
Hi @velo Thanks approved. But build is failed due to the so I ran the formatting plugin locally and force-pushed the fix to simplify the commit history git-code-format:format-code➡️ Commit Apologies for missing that - thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add. two new constructors to RetryableException:
Standardized JavaDoc across all RetryableException constructors
These new constructors remove overload ambiguity when retryAfter is not needed.
Add. a unit test to verify the new constructors.
Fixes #2458