Fix Http2ClientReconnectTest timeout issue in vertx4 module #2955
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the unstable timeout issue in
Http2ClientReconnectTest.allRequestsShouldBeAnswered()
that was causing test failures after 30 seconds.Root Cause
The test was timing out because the asynchronous Future chain was not properly handled by the VertxTestContext. The specific issues were:
CompositeFuture.all(List<Future>)
instead ofFuture.all(List<Future<?>>)
Changes Made
CompositeFuture.all(List<Future>)
toFuture.all(List<Future<?>>)
in thesendRequests
method.onComplete()
handlers to ensure test context receives completion signalstestContext.failNow()
when async operations failTest Results
✅ All vertx4 tests now pass consistently (26 tests, 0 failures, 0 errors)
✅ The specific failing test
Http2ClientReconnectTest.allRequestsShouldBeAnswered()
now completes in ~0.2s instead of timing out after 30sTest Plan
mvn test -pl vertx/feign-vertx4-test -Dtest=Http2ClientReconnectTest
mvn test -pl vertx/feign-vertx4-test
🤖 Generated with Claude Code