Skip to content

Add Prettier configuration and format project files #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

hichemfantar
Copy link
Contributor

Introduce Prettier configuration for consistent code formatting across the project and update relevant files to adhere to the new formatting standards.

Copy link
Member

@yungcomputerchair yungcomputerchair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we limit this to just the app folder? We don't want this formatting things in .github, .vscode, or the README. Prettier should just be used for JS.

@hichemfantar
Copy link
Contributor Author

Wouldn't it be better to enforce the formatting across as many languages as possible?

@yungcomputerchair
Copy link
Member

we definitely don't want huge diffs being committed to, ex, our workflow file with the only tradeoff being opinionated formatting

@hichemfantar
Copy link
Contributor Author

Are you talking in general or about this particular case because I can undo the changes to the workflow file and you can apply those yourself.

@yungcomputerchair
Copy link
Member

Please remove all changes that are not in the app directory and configure the formatter to only apply there as requested.

Copy link
Member

@yungcomputerchair yungcomputerchair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see deltas in rust.yml and README.md; please remove as requested.
On top of that, there are merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants