-
Notifications
You must be signed in to change notification settings - Fork 2
Add Prettier configuration and format project files #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Update TypeScript configuration to exclude 'resources' directory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we limit this to just the app
folder? We don't want this formatting things in .github, .vscode, or the README. Prettier should just be used for JS.
Wouldn't it be better to enforce the formatting across as many languages as possible? |
we definitely don't want huge diffs being committed to, ex, our workflow file with the only tradeoff being opinionated formatting |
Are you talking in general or about this particular case because I can undo the changes to the workflow file and you can apply those yourself. |
Please remove all changes that are not in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still see deltas in rust.yml and README.md; please remove as requested.
On top of that, there are merge conflicts.
Introduce Prettier configuration for consistent code formatting across the project and update relevant files to adhere to the new formatting standards.