Skip to content

DGESVD gives incorrect result #1666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vladimir-ch opened this issue Jul 3, 2018 · 10 comments
Closed

DGESVD gives incorrect result #1666

vladimir-ch opened this issue Jul 3, 2018 · 10 comments
Milestone

Comments

@vladimir-ch
Copy link
Contributor

vladimir-ch commented Jul 3, 2018

Our Gonum test for Dgesvd has recently started to fail when using OpenBLAS as the underlying implementation. I've bisected it to 0144068. As a data point, out of the various test cases that we have it seems to fail only for the matrix sizes 300x600 and 600x300.

@martin-frbg
Copy link
Collaborator

Oh great. :-(
Could you check if this can be repaired by restoring the two instances of &= 0 (lines 428 and 472) that supposedly were no better than the plain =0 that replaced them in the PR ?

@sandwichmaker
Copy link

@oon3m0oo

@vladimir-ch
Copy link
Contributor Author

vladimir-ch commented Jul 3, 2018

Reverting that commit fixes it but just restoring the &= 0 does not.

@martin-frbg
Copy link
Collaborator

Reverted now, thanks again for testing.

@oon3m0oo
Copy link
Contributor

oon3m0oo commented Jul 4, 2018

Interesting. I wonder if it was the movement of the top block of code. There didn't seem to be a dependency there, but I guess there was!

@ViralBShah
Copy link
Contributor

Will there be a quick 0.3.2 with this hotfix?

@martin-frbg
Copy link
Collaborator

Depends on how quick you would want it to be - I am very busy this week, and I would also like to see at least #1673 resolved so that we do not end up with a new single-fix release every two weeks.

@ViralBShah
Copy link
Contributor

Something in a couple of weeks would be great to line up with Julia 0.7. But otherwise we can always pick up the patches too.

timokau added a commit to timokau/nixpkgs that referenced this issue Jul 10, 2018
OpenMathLib/OpenBLAS#1666

Causing test failures in cvxopt and (according to an openblas issue) numpy.
timokau added a commit to timokau/nixpkgs that referenced this issue Jul 11, 2018
OpenMathLib/OpenBLAS#1666

Causing test failures in cvxopt and (according to an openblas issue) numpy.
@timokau
Copy link

timokau commented Jul 11, 2018

I personally think there is nothing wrong with a patch release every two weeks. Better than having a lot of people re-discover the issue and spend time fixing it.

@martin-frbg
Copy link
Collaborator

Closing as 0.3.2 is released now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants