Skip to content

0.3.25: OpenBLAS is not LTO ready #4318

Closed
@kloczek

Description

@kloczek

Just made test with counting different types of compile time warnings

[tkloczko@pers-jacek SPECS]$ rpmbuild -ba openblas.spec --quiet 2>&1 | grep -- \\[-W | sed 's/.*\[//; s/\]//' | sort | uniq -c | sort -nr
  12812 -Wunused-function
   1938 -Wunused-variable
   1052 -Wparentheses
   1050 -Wlto-type-mismatch
    182 -Wunused-dummy-argument
     66 -Wunused-but-set-variable
     23 -Wconversion
     21 -Wunused-label
     10 -Wincompatible-pointer-types
      4 -Wmisleading-indentation
      4 -Wline-truncation
      4 -Winteger-division
      2 -Wformat-contains-nul
      1 -Wuninitialized
      1 -Wdiscarded-qualifiers

All LTO related warnings are trashing that optimisation.
In all those cases someone needs to make decision which one routines declaration is right .. this one on header file or that one used in .c flle.
Biggest number of -Wunused-function warnings may suggest that some functions are identifies as not used because they symbols are not part of the public ABI definition.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions