Skip to content

Work around errors in multithreaded dtrmv #1382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 5, 2017
Merged

Work around errors in multithreaded dtrmv #1382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38763ec
Disable multithreading for trmv
martin-frbg Dec 3, 2017
b414283
Disable gemv unrolling
martin-frbg Dec 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions driver/level2/trmv_U.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,16 @@ int CNAME(BLASLONG m, FLOAT *a, BLASLONG lda, FLOAT *b, BLASLONG incb, FLOAT *bu
COPY_K(m, b, incb, buffer, 1);
}

for (is = 0; is < m; is += DTB_ENTRIES){
/*FIXME the GEMV unrolling performed here was found to be broken, see issue 1332 */
/* Multiplying DTB size by 100 is just a quick-and-dirty hack to disable it for now[B */

min_i = MIN(m - is, DTB_ENTRIES);
for (is = 0; is < m; is += DTB_ENTRIES * 100){

min_i = MIN(m - is, DTB_ENTRIES * 100);

#ifndef TRANSA
if (is > 0){
fprintf(stderr,"WARNING unrolling of the trmv_U loop may give wrong results\n");
GEMV_N(is, min_i, 0, dp1,
a + is * lda, lda,
B + is, 1,
Expand Down
3 changes: 3 additions & 0 deletions interface/trmv.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,9 @@ void CNAME(enum CBLAS_ORDER order, enum CBLAS_UPLO Uplo,
#ifdef SMP
nthreads = num_cpu_avail(2);

/*FIXME trmv_thread was found to be broken, see issue 1332 */
nthreads = 1;

if (nthreads == 1) {
#endif

Expand Down