Fixed a few more unnecessary calls to num_cpu_avail. #1612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't have as many benchmarks for these as for gemm, but it should still make a difference for small matrices.
|
@ashwinyes as this touches thunderx code... |
This was referenced Jun 14, 2018
|
@ashwinyes gentle ping on this. It shouldn't be too terribly controversial since the calls are essentially moot when threading isn't selected. Please do check the logic, though! |
|
Perhaps you could leave the arm64 parts of the PR until later if ashwinyes is busy ? While the changes do look harmless to me, I do not want to be responsible for breaking his Cavium server platform another time |
|
Sorry for the delayed response. I dont have any issue with this PR. You may go ahead with the commit. |
|
Thanks for the review, merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't have as many benchmarks for these as for gemm, but it should still
make a difference for small matrices.