Skip to content

Disable _TRMV parallelism at file top #1995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Disable _TRMV parallelism at file top #1995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
465133e
init
brada4 Feb 3, 2019
ebf443f
clean up trmv interface from scattered workaround
brada4 Feb 3, 2019
d559e65
FIXME
brada4 Feb 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions interface/trmv.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@
#include "functable.h"
#endif

/* FIXME trmv_thread was found to be broken, see issue 1332 */
#undef SMP

#ifdef XDOUBLE
#define ERROR_NAME "QTRMV "
#elif defined(DOUBLE)
Expand Down Expand Up @@ -218,11 +221,8 @@ void CNAME(enum CBLAS_ORDER order, enum CBLAS_UPLO Uplo,
buffer = (FLOAT *)blas_memory_alloc(1);

#ifdef SMP
/* nthreads = num_cpu_avail(2);
nthreads = num_cpu_avail(2);

FIXME trmv_thread was found to be broken, see issue 1332 */
nthreads = 1;

if (nthreads == 1) {
#endif

Expand Down
7 changes: 4 additions & 3 deletions interface/ztrmv.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@
/* or implied, of The University of Texas at Austin. */
/*********************************************************************/


/* FIXME TRMV multithreading appears to be broken, see issue 1332*/
#undef SMP

#include <stdio.h>
#include <ctype.h>
#include "common.h"
Expand Down Expand Up @@ -239,9 +243,6 @@ void CNAME(enum CBLAS_ORDER order, enum CBLAS_UPLO Uplo,
} else
nthreads = 1;

/* FIXME TRMV multithreading appears to be broken, see issue 1332*/
nthreads = 1;

if(nthreads > 1) {
buffer_size = n > 16 ? 0 : n * 4 + 40;
}
Expand Down