Skip to content

Fix declaration of input arguments in x86_64 GEMV, SYMV and DSCAL #2010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 12, 2019
Merged

Fix declaration of input arguments in x86_64 GEMV, SYMV and DSCAL #2010

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dc6ac9e
Fix declaration of input arguments in the x86_64 s/dGEMV_T and s/dGE…
martin-frbg Feb 12, 2019
91481a3
Fix declaration of input arguments in inline assembly
martin-frbg Feb 12, 2019
b824fa7
Fix declaration of assembly arguments in SSYMV and DSYMV microkernels
martin-frbg Feb 12, 2019
ab1630f
Fix declaration of arguments in inline assembly
martin-frbg Feb 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions kernel/x86_64/dgemv_n_4.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,9 @@ static void dgemv_kernel_4x2( BLASLONG n, FLOAT **ap, FLOAT *x, FLOAT *y, FLOAT
"jnz 1b \n\t"

:
:
"r" (i), // 0
"r" (n), // 1
"+r" (i), // 0
"+r" (n) // 1
:
"r" (x), // 2
"r" (y), // 3
"r" (ap[0]), // 4
Expand Down Expand Up @@ -166,9 +166,9 @@ static void dgemv_kernel_4x1(BLASLONG n, FLOAT *ap, FLOAT *x, FLOAT *y, FLOAT *a
"jnz 1b \n\t"

:
"+r" (i), // 0
"+r" (n) // 1
:
"r" (i), // 0
"r" (n), // 1
"r" (x), // 2
"r" (y), // 3
"r" (ap), // 4
Expand Down
18 changes: 9 additions & 9 deletions kernel/x86_64/dgemv_t_4.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,9 +127,9 @@ static void dgemv_kernel_4x2(BLASLONG n, FLOAT *ap0, FLOAT *ap1, FLOAT *x, FLOAT
"movsd %%xmm11,8(%2) \n\t"

:
:
"r" (i), // 0
"r" (n), // 1
"+r" (i), // 0
"+r" (n) // 1
:
"r" (y), // 2
"r" (ap0), // 3
"r" (ap1), // 4
Expand Down Expand Up @@ -195,9 +195,9 @@ static void dgemv_kernel_4x1(BLASLONG n, FLOAT *ap, FLOAT *x, FLOAT *y)
"movsd %%xmm10, (%2) \n\t"

:
:
"r" (i), // 0
"r" (n), // 1
"+r" (i), // 0
"+r" (n) // 1
:
"r" (y), // 2
"r" (ap), // 3
"r" (x) // 4
Expand Down Expand Up @@ -259,9 +259,9 @@ static void add_y(BLASLONG n, FLOAT da , FLOAT *src, FLOAT *dest, BLASLONG inc_d
"jnz 1b \n\t"

:
:
"r" (i), // 0
"r" (n), // 1
"+r" (i), // 0
"+r" (n) // 1
:
"r" (&da), // 2
"r" (src), // 3
"r" (dest) // 4
Expand Down
2 changes: 1 addition & 1 deletion kernel/x86_64/dscal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,8 @@ static void dscal_kernel_inc_8(BLASLONG n, FLOAT *alpha, FLOAT *x, BLASLONG inc_
"jnz 1b \n\t"

:
"+r" (n) // 0
:
"r" (n), // 0
"r" (x), // 1
"r" (x1), // 2
"r" (alpha), // 3
Expand Down
4 changes: 2 additions & 2 deletions kernel/x86_64/dsymv_L_microk_bulldozer-2.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,8 @@ static void dsymv_kernel_4x4(BLASLONG from, BLASLONG to, FLOAT **a, FLOAT *x, FL
"vmovsd %%xmm3 ,24(%9) \n\t" // save temp2

:
:
"r" (from), // 0
"+r" (from) // 0
:
"r" (to), // 1
"r" (x), // 2
"r" (y), // 3
Expand Down
4 changes: 2 additions & 2 deletions kernel/x86_64/dsymv_L_microk_haswell-2.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,8 @@ static void dsymv_kernel_4x4(BLASLONG from, BLASLONG to, FLOAT **a, FLOAT *x, FL
"vzeroupper \n\t"

:
:
"r" (from), // 0
"+r" (from) // 0
:
"r" (to), // 1
"r" (x), // 2
"r" (y), // 3
Expand Down
4 changes: 2 additions & 2 deletions kernel/x86_64/dsymv_L_microk_nehalem-2.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,8 @@ static void dsymv_kernel_4x4(BLASLONG from, BLASLONG to, FLOAT **a, FLOAT *x, FL
"movsd %%xmm3 , 24(%9) \n\t" // save temp2

:
:
"r" (from), // 0
"+r" (from) // 0
:
"r" (to), // 1
"r" (x), // 2
"r" (y), // 3
Expand Down
4 changes: 2 additions & 2 deletions kernel/x86_64/dsymv_L_microk_sandy-2.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,8 @@ static void dsymv_kernel_4x4(BLASLONG from, BLASLONG to, FLOAT **a, FLOAT *x, FL
"vzeroupper \n\t"

:
:
"r" (from), // 0
"+r" (from) // 0
:
"r" (to), // 1
"r" (x), // 2
"r" (y), // 3
Expand Down
6 changes: 3 additions & 3 deletions kernel/x86_64/dsymv_U_microk_bulldozer-2.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,9 @@ static void dsymv_kernel_4x4(BLASLONG n, FLOAT *a0, FLOAT *a1, FLOAT *a2, FLOAT
"vmovsd %%xmm3 ,24(%9) \n\t" // save temp2

:
:
"r" (i), // 0
"r" (n), // 1
"+r" (i), // 0
"+r" (n) // 1
:
"r" (x), // 2
"r" (y), // 3
"r" (a0), // 4
Expand Down
6 changes: 3 additions & 3 deletions kernel/x86_64/dsymv_U_microk_haswell-2.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,9 @@ static void dsymv_kernel_4x4(BLASLONG n, FLOAT *a0, FLOAT *a1, FLOAT *a2, FLOAT
"vzeroupper \n\t"

:
:
"r" (i), // 0
"r" (n), // 1
"+r" (i), // 0
"+r" (n) // 1
:
"r" (x), // 2
"r" (y), // 3
"r" (a0), // 4
Expand Down
6 changes: 3 additions & 3 deletions kernel/x86_64/dsymv_U_microk_nehalem-2.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,9 @@ static void dsymv_kernel_4x4(BLASLONG n, FLOAT *a0, FLOAT *a1, FLOAT *a2, FLOAT
"movsd %%xmm3 , 24(%9) \n\t" // save temp2

:
:
"r" (i), // 0
"r" (n), // 1
"+r" (i), // 0
"+r" (n) // 1
:
"r" (x), // 2
"r" (y), // 3
"r" (a0), // 4
Expand Down
6 changes: 3 additions & 3 deletions kernel/x86_64/dsymv_U_microk_sandy-2.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,9 @@ static void dsymv_kernel_4x4(BLASLONG n, FLOAT *a0, FLOAT *a1, FLOAT *a2, FLOAT
"vzeroupper \n\t"

:
:
"r" (i), // 0
"r" (n), // 1
"+r" (i), // 0
"+r" (n) // 1
:
"r" (x), // 2
"r" (y), // 3
"r" (a0), // 4
Expand Down
14 changes: 7 additions & 7 deletions kernel/x86_64/sgemv_n_4.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,9 +149,9 @@ static void sgemv_kernel_4x2( BLASLONG n, FLOAT **ap, FLOAT *x, FLOAT *y, FLOAT
"jnz 1b \n\t"

:
:
"r" (i), // 0
"r" (n), // 1
"+r" (i), // 0
"+r" (n) // 1
:
"r" (x), // 2
"r" (y), // 3
"r" (ap[0]), // 4
Expand Down Expand Up @@ -223,9 +223,9 @@ static void sgemv_kernel_4x1(BLASLONG n, FLOAT *ap, FLOAT *x, FLOAT *y, FLOAT *a

"3: \n\t"
:
"+r" (i), // 0
"+r" (n1) // 1
:
"r" (i), // 0
"r" (n1), // 1
"r" (x), // 2
"r" (y), // 3
"r" (ap), // 4
Expand Down Expand Up @@ -277,9 +277,9 @@ static void add_y(BLASLONG n, FLOAT *src, FLOAT *dest, BLASLONG inc_dest)
"jnz 1b \n\t"

:
"+r" (i), // 0
"+r" (n) // 1
:
"r" (i), // 0
"r" (n), // 1
"r" (src), // 2
"r" (dest) // 3
: "cc",
Expand Down
18 changes: 9 additions & 9 deletions kernel/x86_64/sgemv_t_4.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,9 +139,9 @@ static void sgemv_kernel_4x2(BLASLONG n, FLOAT *ap0, FLOAT *ap1, FLOAT *x, FLOAT
"movss %%xmm11,4(%2) \n\t"

:
:
"r" (i), // 0
"r" (n), // 1
"+r" (i), // 0
"+r" (n) // 1
:
"r" (y), // 2
"r" (ap0), // 3
"r" (ap1), // 4
Expand Down Expand Up @@ -208,9 +208,9 @@ static void sgemv_kernel_4x1(BLASLONG n, FLOAT *ap, FLOAT *x, FLOAT *y)
"movss %%xmm10, (%2) \n\t"

:
:
"r" (i), // 0
"r" (n), // 1
"+r" (i), // 0
"+r" (n) // 1
:
"r" (y), // 2
"r" (ap), // 3
"r" (x) // 4
Expand Down Expand Up @@ -272,9 +272,9 @@ static void add_y(BLASLONG n, FLOAT da , FLOAT *src, FLOAT *dest, BLASLONG inc_d
"jnz 1b \n\t"

:
:
"r" (i), // 0
"r" (n), // 1
"+r" (i), // 0
"+r" (n) // 1
:
"r" (&da), // 2
"r" (src), // 3
"r" (dest) // 4
Expand Down
4 changes: 2 additions & 2 deletions kernel/x86_64/ssymv_L_microk_bulldozer-2.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,8 @@ static void ssymv_kernel_4x4(BLASLONG from, BLASLONG to, FLOAT **a, FLOAT *x, FL
"vmovss %%xmm3 ,12(%9) \n\t" // save temp2

:
:
"r" (from), // 0
"+r" (from) // 0
:
"r" (to), // 1
"r" (x), // 2
"r" (y), // 3
Expand Down
4 changes: 2 additions & 2 deletions kernel/x86_64/ssymv_L_microk_haswell-2.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,8 @@ static void ssymv_kernel_4x4(BLASLONG from, BLASLONG to, FLOAT **a, FLOAT *x, FL
"vzeroupper \n\t"

:
:
"r" (from), // 0
"+r" (from) // 0
:
"r" (to), // 1
"r" (x), // 2
"r" (y), // 3
Expand Down
4 changes: 2 additions & 2 deletions kernel/x86_64/ssymv_L_microk_nehalem-2.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,8 @@ static void ssymv_kernel_4x4(BLASLONG from, BLASLONG to, FLOAT **a, FLOAT *x, F
"movss %%xmm3 , 12(%9) \n\t" // save temp2

:
:
"r" (from), // 0
"+r" (from) // 0
:
"r" (to), // 1
"r" (x), // 2
"r" (y), // 3
Expand Down
8 changes: 4 additions & 4 deletions kernel/x86_64/ssymv_L_microk_sandy-2.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,8 @@ static void ssymv_kernel_4x4(BLASLONG from, BLASLONG to, FLOAT **a, FLOAT *x, FL
"vzeroupper \n\t"

:
:
"r" (from), // 0
"+r" (from) // 0
:
"r" (to), // 1
"r" (x), // 2
"r" (y), // 3
Expand Down Expand Up @@ -217,8 +217,8 @@ static void ssymv_kernel_4x4(BLASLONG from, BLASLONG to, FLOAT **a, FLOAT *x, FL
"vzeroupper \n\t"

:
:
"r" (from), // 0
"+r" (from) // 0
:
"r" (to), // 1
"r" (x), // 2
"r" (y), // 3
Expand Down
6 changes: 3 additions & 3 deletions kernel/x86_64/ssymv_U_microk_bulldozer-2.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,9 @@ static void ssymv_kernel_4x4(BLASLONG n, FLOAT *a0, FLOAT *a1, FLOAT *a2, FLOAT
"vmovss %%xmm3 ,12(%9) \n\t" // save temp2

:
:
"r" (i), // 0
"r" (n), // 1
"+r" (i), // 0
"+r" (n) // 1
:
"r" (x), // 2
"r" (y), // 3
"r" (a0), // 4
Expand Down
6 changes: 3 additions & 3 deletions kernel/x86_64/ssymv_U_microk_haswell-2.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,9 +112,9 @@ static void ssymv_kernel_4x4(BLASLONG n, FLOAT *a0, FLOAT *a1, FLOAT *a2, FLOAT
"vzeroupper \n\t"

:
:
"r" (i), // 0
"r" (n), // 1
"+r" (i), // 0
"+r" (n) // 1
:
"r" (x), // 2
"r" (y), // 3
"r" (a0), // 4
Expand Down
6 changes: 3 additions & 3 deletions kernel/x86_64/ssymv_U_microk_nehalem-2.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,9 @@ static void ssymv_kernel_4x4(BLASLONG n, FLOAT *a0, FLOAT *a1, FLOAT *a2, FLOAT
"movss %%xmm3 , 12(%9) \n\t" // save temp2

:
:
"r" (i), // 0
"r" (n), // 1
"+r" (i), // 0
"+r" (n) // 1
:
"r" (x), // 2
"r" (y), // 3
"r" (a0), // 4
Expand Down
6 changes: 3 additions & 3 deletions kernel/x86_64/ssymv_U_microk_sandy-2.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,9 +120,9 @@ static void ssymv_kernel_4x4(BLASLONG n, FLOAT *a0, FLOAT *a1, FLOAT *a2, FLOAT
"vzeroupper \n\t"

:
:
"r" (i), // 0
"r" (n), // 1
"+r" (i), // 0
"+r" (n) // 1
:
"r" (x), // 2
"r" (y), // 3
"r" (a0), // 4
Expand Down