Correct generation of GETRF files by the CMAKE build

[martin-frbg]

fixes #2396

[marxin]

You found it, good job! It seems to me a more common problem and I have one suggestion. Instead of:

#define MAXPS	maxps
#define MAXSS	maxss
#ifdef USE_MIN
#define MAXPS	minps
#define MAXSS	minss
#endif

I would rather use:

#if defined(USE_MAX)
#define MAXPS	maxps
#define MAXSS	maxss
#elif defined(USE_MIN)
#define MAXPS	minps
#define MAXSS	minss
#else
#error Neither USE_MAX nor USE_MIN is defined
#endif

It will take some time to change it but it may pay off in the future?

[martin-frbg]

Err, that comment belongs to the iamax_sse.S of #2414 or what ? I do not see a relevance to the -DUNIT problem here (where the #define plays a role in the included common.h) and neither will anybody who may try to understand code changes through reading the associated git history a few months from now.

[marxin]

No, it's related to this issue as well. It's about a missing macro definition. In the case of USE_MIN, if you forget to define it somewhere you end up with a wrong code. With my suggestion, you will end up with a compilation error. That seems to me much nicer than a silent miscompilation.