Increase BUFFER_SIZEs and add a safeguard; supply GEMM_R for POWER8/9 #2551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_R for POWER8/9 As shown in #2538, default buffersizes on some platforms were smaller than required in memory.c and the requirement could never be fulfilled for a calculated GEMM_R on PPC given the fomula used
This was referenced Apr 24, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As shown in #2538, the default value for BUFFER_SIZE was smaller than the actual requirement as calculated from the GEMM parameters on ARM64. This turns out to be the case on x86_64 Haswell and SkylakeX platform as well as ARM and ZARCH too.
Furthermore, the formula to derive GEMM_R values not supplied in param.h would never allow the BUFFER_SIZE requirement to be fulfilled, so matching values were calculated for POWER8 and 9.
Fixes #2538 following the suggestion of akobotov there and extending it to other affected architectures.