Allocate an auxiliary struct when running out of preconfigured threads #3352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-frbg
changed the title
This was
linked to
issues
Aug 29, 2021
|
Trying this out in MacPython/openblas-libs#66 |
isuruf
reviewed
Sep 1, 2021
| @@ -73,6 +73,16 @@ USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | |||
|
|
|||
| #include "common.h" | |||
|
|
|||
| #ifndef likely | |||
| #ifdef __GNUC__ | |||
There was a problem hiding this comment.
How about #if defined(__GNUC__) || defined(__clang__) ?
There was a problem hiding this comment.
is clang likely to understand this (across all relevant versions) ? I copied this from the blas_server* files...
There was a problem hiding this comment.
clang 3.8 does which was released 5 years ago. That's the oldest I have access to. Here's what boost does, https://github.com/boostorg/config/blob/develop/include/boost/config/compiler/clang.hpp#L71-L77
This was referenced Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #3321