Make sure that Netlib LAPACK respects FFLAGS #3390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenBLAS allows users to specify `FFLAGS` and then uses `override` to append additional options. However, without such an override in lapack's make.inc, lapack would use the external FFLAGS, rather than the ones being computed by OpenBLAS. For example the `DEBUG=1` flag would not apply to LAPACK code. This is all a bit messy but forced by the integration with netlib lapack. Note that `CFLAGS` already has this override for the same reason. It is possible that other variables here should have a similar override, but I think for most of the other ones, OpenBLAS's build system does not append to the flags passed in by the user.
staticfloat
approved these changes
Oct 1, 2021
|
Right, thanks. The overrides have been added on a case-by-case basis so far, and I do not think any of the remaining variables need them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenBLAS allows users to specify
FFLAGSand then usesoverrideto append additionaloptions. However, without such an override in lapack's make.inc, lapack would use the external
FFLAGS, rather than the ones being computed by OpenBLAS. For example the
DEBUG=1flagwould not apply to LAPACK code. This is all a bit messy but forced by the integration with netlib
lapack. Note that
CFLAGSalready has this override for the same reason. It is possible thatother variables here should have a similar override, but I think for most of the other ones, OpenBLAS's
build system does not append to the flags passed in by the user.
cc @staticfloat @ianatol