Skip to content

Fix miscounting of threadpool size on Linux with OMP_PROC_BIND=TRUE #3437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 4, 2021
Merged

Fix miscounting of threadpool size on Linux with OMP_PROC_BIND=TRUE #3437

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
46cc347
sched_getaffinity will not return all accessible cores with OMP_PROC_…
martin-frbg Nov 2, 2021
9249259
return OMP places for thread count when built with OpenMP
martin-frbg Nov 3, 2021
85401a0
old OpenMP versions lack omp_get_num_places
martin-frbg Nov 3, 2021
0e6639d
Fix missing endif and rearrange for non-Linux OpenMP
martin-frbg Nov 3, 2021
e53408c
remove extraneous endif
martin-frbg Nov 3, 2021
36c7b84
Update memory.c
martin-frbg Nov 3, 2021
faa066c
need openmp 4.5 for get_num_places
martin-frbg Nov 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion driver/others/memory.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,14 @@ int get_num_procs(void) {
#endif

if (!nums) nums = sysconf(_SC_NPROCESSORS_CONF);

#if defined(USE_OPENMP)
#if _OPENMP >= 201511
nums = omp_get_num_places();
#endif
return nums;
#endif

#if !defined(OS_LINUX)
return nums;
#endif
Expand Down Expand Up @@ -1806,10 +1814,19 @@ int get_num_procs(void) {
#endif

if (!nums) nums = sysconf(_SC_NPROCESSORS_CONF);

#if defined(USE_OPENMP)
/* if (omp_get_proc_bind() != omp_proc_bind_false) */
#if _OPENMP >= 201511
nums = omp_get_num_places();
#endif
return nums;
#endif

#if !defined(OS_LINUX)
return nums;
#endif

#if !defined(__GLIBC_PREREQ)
return nums;
#else
Expand Down