Fixed error in common.h for Android compilation introduced by e12cf11 #630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xianyi
added a commit
that referenced
this pull request
Sep 4, 2015
Fixed error in common.h for Android compilation introduced by e12cf11
jirutka
referenced
this pull request
Jul 24, 2017
This was referenced Jul 24, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that even with short-circuiting of the && operator, preprocessor fails when using __GLIBC_PREREQ(2, 17) if undefined.
This will happen when trying to compile for Android. Splitting the if condition in two parts solves it.