fixed coverage attention, and translator for attn_debug #2272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you. Were you also able to check the copy attention mechanism with this new v3 version ? |
|
yes, I've checked the coverage mechanism with the copy mechanism. it worked well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed
coverage_attnbugs which has been discussed on #2013.Actual codes are slightly differ from it due to considering inference(non teacher-forcing) stage. (See comment)
https://github.com/Sanghyuk-Choi/OpenNMT-py/blob/coverage_fix/onmt/decoders/decoder.py#L364-L365
I've tested the code working properly with dummy dataset as it described on the original paper.
Also, This PR includes
_build_source_tokensontranslation.py, sincesrc_raw = Nonecauses error when--attn_debug = True.