Skip to content

Conversation

RoosterDragon
Copy link
Member

  • Tweak the Update and Remove methods to reduce the number of dictionary lookups required.
  • Change the Update method to an indexer, this allows simplifying callers who wanted to AddOrUpdate a value.
  • Implement IDictionary<T, Rectangle>, since the class already implements these semantics by providing a backing store of the bounds for each item.
  • Clean up some naming to use the generic item instead of actor.
  • Make the MutateBins action methods static.

- Tweak the Update and Remove methods to reduce the number of dictionary lookups required.
- Change the Update method to an indexer, this allows simplifying callers who wanted to AddOrUpdate a value.
- Implement IDictionary<T, Rectangle>, since the class already implements these semantics by providing a backing store of the bounds for each item.
- Clean up some naming to use the generic `item` instead of `actor`.
- Make the MutateBins action methods static.
Copy link
Member

@PunkPun PunkPun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@PunkPun PunkPun merged commit ce3ad6f into OpenRA:bleed Feb 22, 2025
2 checks passed
@PunkPun
Copy link
Member

PunkPun commented Feb 22, 2025

changelog

@RoosterDragon RoosterDragon deleted the partitioned branch March 1, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants