-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Closed
Labels
Platform: macOSDenotes that the item is relevant to macOS users or macOS-specific environmentsDenotes that the item is relevant to macOS users or macOS-specific environmentsType: Feature RequestIdentifies requests for new features or enhancements. These involve proposing new improvements.Identifies requests for new features or enhancements. These involve proposing new improvements.blocked upstreamThis fix or new feature requires changes in a library we rely onThis fix or new feature requires changes in a library we rely onhelp wantedAn issue that we would love anyone to help us withAn issue that we would love anyone to help us withjythonUses of Python as expression language via JythonUses of Python as expression language via JythonpackagingHow we distribute OpenRefine to end users, on various operating systemsHow we distribute OpenRefine to end users, on various operating systems
Description
The fact that we depend on the jython-standalone
distribution prevents us from signing our MacOS package and notarizing it with Apple.
To Reproduce
Check the CI logs here:
https://github.com/OpenRefine/OpenRefine/runs/5335255475?check_suite_focus=true
Current Results
When notarizing our DMG build, we get the following errors:
[INFO] [exec] "issues": [
[INFO] [exec] {
[INFO] [exec] "severity": "error",
[INFO] [exec] "code": null,
[INFO] [exec] "path": "openrefine-mac-3.6-SNAPSHOT.dmg/OpenRefine.app/Contents/Resources/webapp/extensions/jython/module/MOD-INF/lib/jython-standalone-2.7.2.jar/jni/Darwin/libjffi-1.2.jnilib",
[INFO] [exec] "message": "The binary uses an SDK older than the 10.9 SDK.",
[INFO] [exec] "docUrl": null,
[INFO] [exec] "architecture": "i386"
[INFO] [exec] },
[INFO] [exec] {
[INFO] [exec] "severity": "error",
[INFO] [exec] "code": null,
[INFO] [exec] "path": "openrefine-mac-3.6-SNAPSHOT.dmg/OpenRefine.app/Contents/Resources/webapp/extensions/jython/module/MOD-INF/lib/jython-standalone-2.7.2.jar/jni/Darwin/libjffi-1.2.jnilib",
[INFO] [exec] "message": "The binary uses an SDK older than the 10.9 SDK.",
[INFO] [exec] "docUrl": null,
[INFO] [exec] "architecture": "x86_64"
[INFO] [exec] }
[INFO] [exec] ]
Expected Behavior
Successful notarization.
Additional context
We might be able to switch to jython-slim
which should also let us save some megabytes (but some additional dependencies are probably pulled in then)
Funding available
The OpenRefine project has funding available to work on this. Do you know someone who would be able to get this fixed? Send them our way!
https://openrefine.org/blog/2022/09/30/windows-macos-packaging.html
Metadata
Metadata
Assignees
Labels
Platform: macOSDenotes that the item is relevant to macOS users or macOS-specific environmentsDenotes that the item is relevant to macOS users or macOS-specific environmentsType: Feature RequestIdentifies requests for new features or enhancements. These involve proposing new improvements.Identifies requests for new features or enhancements. These involve proposing new improvements.blocked upstreamThis fix or new feature requires changes in a library we rely onThis fix or new feature requires changes in a library we rely onhelp wantedAn issue that we would love anyone to help us withAn issue that we would love anyone to help us withjythonUses of Python as expression language via JythonUses of Python as expression language via JythonpackagingHow we distribute OpenRefine to end users, on various operating systemsHow we distribute OpenRefine to end users, on various operating systems