Database Extension: input validation for database connection data #2151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wetneb
reviewed
Sep 9, 2019
There was a problem hiding this comment.
Thanks a lot Tonio for tackling this!
I would have intuitively gone for a different approach: HTML-sanitize the DB credentials before rendering them to the DOM, directly in the JS frontend. Did I miss any reason why this would not work? See the comments inline.
extensions/database/src/com/google/refine/extension/database/cmd/SavedConnectionCommand.java
Outdated
Show resolved
Hide resolved
.../database/tests/src/com/google/refine/extension/database/cmd/SavedConnectionCommandTest.java
Outdated
Show resolved
Hide resolved
.../database/tests/src/com/google/refine/extension/database/cmd/SavedConnectionCommandTest.java
Outdated
Show resolved
Hide resolved
|
@tcbuzor Thanks Tony for continuing to work on this! Much appreciated! |
wetneb
reviewed
Sep 22, 2019
| var a = $('<a href="#" class="pure-menu-link context-menu-one"></a>').appendTo(li); | ||
| $('<span class="context-menu-text"></span>').text(savedConnection.connectionName) | ||
| .appendTo(a); | ||
| $('<span class="sc-context-more-vert pull-right"> </span>').appendTo(a); |
There was a problem hiding this comment.
This is a better way to construct DOM elements in jQuery: just use the text() method of a jQuery element, which already does the escaping for you.
In general, all user-supplied text should be inserted in this way in the UI. Manually concatenating HTML code in JavaScript is a bad sign.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate Connection input data from frontend and backend. Sanitize database connection information before adding to the DOM.