Skip to content

Conversation

hhvrc
Copy link
Contributor

@hhvrc hhvrc commented Aug 15, 2025

Much more lightweight backend communication

@hhvrc hhvrc requested a review from LucHeart August 15, 2025 20:12
@hhvrc hhvrc self-assigned this Aug 15, 2025
@hhvrc hhvrc marked this pull request as ready for review September 1, 2025 14:22
@hhvrc
Copy link
Contributor Author

hhvrc commented Sep 1, 2025

Review this @codex 🤔

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex Review: Here are some suggestions.

Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

@LucHeart LucHeart requested a review from Copilot September 1, 2025 17:40
Copilot

This comment was marked as outdated.

@LucHeart LucHeart requested a review from Copilot September 1, 2025 19:10
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements binary serialization for backchannel communications to make backend communication more lightweight. The changes replace JSON-based Redis pub/sub messaging with MessagePack serialization and restructure the messaging system.

Key changes:

  • Replace JSON serialization with MessagePack for Redis pub/sub messages
  • Consolidate multiple Redis channels into device-specific channels with typed payloads
  • Extract control logic into a dedicated service with improved error handling

Reviewed Changes

Copilot reviewed 38 out of 38 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
LiveControlGateway/PubSub/RedisSubscriberService.cs Removed JSON-based Redis subscriber service entirely
Common/Redis/PubSub/*.cs Replaced JSON message classes with MessagePack-based unified message types
Common/Services/RedisPubSub/RedisPubService.cs Updated to use MessagePack serialization and new message structure
Common/Services/ControlSender.cs New service extracting control logic with improved error handling
LiveControlGateway/LifetimeManager/HubLifetime.cs Updated to consume MessagePack messages from device-specific channels
Common/Models/SharePermsAndLimits.cs Consolidated permission models into single class

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@hhvrc hhvrc merged commit 196fcad into develop Sep 1, 2025
4 checks passed
@hhvrc hhvrc deleted the feature/binary-backchannel-comms branch September 1, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant