-
Notifications
You must be signed in to change notification settings - Fork 10
Implement binary serialization for backchannel comms #231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Review this @codex 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codex Review: Here are some suggestions.
Reply with @codex fix comments
to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements binary serialization for backchannel communications to make backend communication more lightweight. The changes replace JSON-based Redis pub/sub messaging with MessagePack serialization and restructure the messaging system.
Key changes:
- Replace JSON serialization with MessagePack for Redis pub/sub messages
- Consolidate multiple Redis channels into device-specific channels with typed payloads
- Extract control logic into a dedicated service with improved error handling
Reviewed Changes
Copilot reviewed 38 out of 38 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
LiveControlGateway/PubSub/RedisSubscriberService.cs | Removed JSON-based Redis subscriber service entirely |
Common/Redis/PubSub/*.cs | Replaced JSON message classes with MessagePack-based unified message types |
Common/Services/RedisPubSub/RedisPubService.cs | Updated to use MessagePack serialization and new message structure |
Common/Services/ControlSender.cs | New service extracting control logic with improved error handling |
LiveControlGateway/LifetimeManager/HubLifetime.cs | Updated to consume MessagePack messages from device-specific channels |
Common/Models/SharePermsAndLimits.cs | Consolidated permission models into single class |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Much more lightweight backend communication